Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ec2: add page #4661

Merged
merged 1 commit into from
Oct 12, 2020
Merged

aws-ec2: add page #4661

merged 1 commit into from
Oct 12, 2020

Conversation

eshack94
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-ec2.md:26: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from 81b6533 to 278af05 Compare October 12, 2020 10:09
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/aws-ec2.md:26: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from 278af05 to ed05a7b Compare October 12, 2020 10:10
@mebeim mebeim added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 12, 2020
@navarroaxel navarroaxel changed the title aws ec2: Add entry aws-ec2: add page Oct 12, 2020
navarroaxel
navarroaxel requested changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eshack94, just a few comments

@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from ed05a7b to 6574bc9 Compare October 12, 2020 13:44
@eshack94 eshack94 requested a review from navarroaxel October 12, 2020 13:46
@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from 6574bc9 to 45c4f2e Compare October 12, 2020 19:34
@eshack94 eshack94 requested a review from navarroaxel October 12, 2020 19:34
navarroaxel
navarroaxel requested changes Oct 12, 2020
View reviewed changes
navarroaxel
navarroaxel requested changes Oct 12, 2020
View reviewed changes
@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from 45c4f2e to b7d8ae2 Compare October 12, 2020 19:38
@eshack94 eshack94 force-pushed the add-awscli-ec2-commands branch from b7d8ae2 to de5d3e5 Compare October 12, 2020 19:39
sbrl
sbrl approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eshack94!

@sbrl sbrl merged commit 6b248c8 into tldr-pages:master Oct 12, 2020
@kbdharun kbdharun mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eshack94 @tldr-bot @navarroaxel @sbrl @mebeim