Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple pages: normalize "more information" labels #5140

Merged
merged 11 commits into from
Jan 15, 2021
Merged

multiple pages: normalize "more information" labels #5140

merged 11 commits into from
Jan 15, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jan 13, 2021 •
edited
Loading

This PR normalizes the "more information" labels in the all translations of all pages.

I picked each label based on the most common one in the pages.* folder. Usually there are 1% or 2% are strange labels and 95%+ are the same, e.g. for German:

Mehr Information:                = 2
Mehr Informationen:              = 59
Mehr informationen:              = 2
Weitere Informationen zu Cradle: = 1
Weitere Informationen:           = 21
Weitere informationen:           = 1

Labels decided on:

  • German (de): Mehr Informationen:

@bl-ue
German pages: normalize "more information" labels
67c15ea 
Use "Mehr Informationen:" as the standard "more information" label
for external links in descriptions of pages.
@bl-ue bl-ue added bug Issues with our clients or rendering of pages, etc. page edit Changes to an existing page(s). syntax Issues related to the content and markup of the pages. mass changes Changes that affect multiple pages. translation Translate pages from one language to another. labels Jan 13, 2021
@bl-ue bl-ue marked this pull request as draft January 13, 2021 16:07
@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 13, 2021

@waldyrious @mebeim looks good so far?

mebeim
mebeim approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bl-ue I don't speak German, but it seems reasonable to convert everything to the most common phrasing 👍

bl-ue added 6 commits January 15, 2021 09:23
@bl-ue
Spanish pages: normalize "more information" labels
deec1a3 
Use "Más información:" as the standard "more information" label
for external links in descriptions of pages.
@bl-ue
French pages: normalize "more information" labels
df8c0a3 
Use "Plus d'informations :" as the standard "more information" label
for external links in descriptions of pages.
@bl-ue
Indonesian pages: normalize "more information" phrase
8c9c45c 
Use "Informasi lebih lanjut:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Italian pages: normalize "more information" phrase
042a7e1 
Use "Maggiori informazioni:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Japanese pages: normalize "more information" phrase
be348b6 
Use "詳しくはこちら:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Korean pages: normalize "more information" phrase
c9f1dee 
Use "더 많은 정보:" as the standard "more information" phrase for external links at
the top of pages.
bl-ue added 4 commits January 15, 2021 10:29
@bl-ue
Portaguese (Brazilian) pages: normalize "more information" phrase
ea70b85 
Use "Mais informações:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Russian pages: normalize "more information" phrase
90258d3 
Use "Больше информации:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Tamil pages: normalize "more information" phrase
03495bb 
Use "மேலும் தகவல்:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue
Chinese pages: normalize "more information" phrase
8968ea6 
Use "更多信息:" as the standard "more information" phrase for external links at
the top of pages.
@bl-ue bl-ue marked this pull request as ready for review January 15, 2021 15:41
owenvoke
owenvoke approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! That's a lot of pages. Brilliant work @bl-ue.

Let's make sure to rebase this when merging to keep the commit history. 👍🏻

@schneiderl schneiderl merged commit c59f12a into master Jan 15, 2021
@bl-ue bl-ue deleted the bl-ue/normalize-more-info-translations branch January 15, 2021 17:29
@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 15, 2021 •
edited
Loading

@schneiderl this was supposed to be rebased...

@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 15, 2021

But it doesn't really matter. Only 11 commits :)

@sbrl
Copy link
Member

sbrl commented Jan 16, 2021

Those commit messages look fine to be rebased and not squashed, @bl-ue :-)

@waldyrious
Copy link
Member

@sbrl that's precisely what he's saying :) @owenvoke had proposed to do a rebase merge, but when @schneiderl merged the PR, he used a squash merge instead.

@schneiderl
Copy link
Collaborator

I'm sorry about that 🦖

@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 18, 2021

No worries @schneiderl! :D

@navarroaxel navarroaxel mentioned this pull request Feb 2, 2021
Closed
@bl-ue bl-ue mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mebeim mebeim mebeim approved these changes

@schneiderl schneiderl schneiderl approved these changes

@owenvoke owenvoke owenvoke approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

@einverne einverne Awaiting requested review from einverne

@MasterOdin MasterOdin Awaiting requested review from MasterOdin

@sbrl sbrl Awaiting requested review from sbrl

@waldyrious waldyrious Awaiting requested review from waldyrious

@zlatanvasovic zlatanvasovic Awaiting requested review from zlatanvasovic

Assignees
No one assigned
Labels
bug Issues with our clients or rendering of pages, etc. mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). syntax Issues related to the content and markup of the pages. translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bl-ue @sbrl @waldyrious @schneiderl @owenvoke @mebeim