Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync: add Chinese translation #5200

Merged
merged 7 commits into from
Feb 2, 2021
Merged

rsync: add Chinese translation #5200

merged 7 commits into from
Feb 2, 2021

Conversation

xiaolong-666
Copy link
Contributor

@xiaolong-666 xiaolong-666 commented Jan 29, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2021

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages.zh/common/rsync.md:36 MD047/single-trailing-newline Files should end with a single newline character

Please fix the error(s) and push again.

@bl-ue bl-ue added the translation Translate pages from one language to another. label Jan 29, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the page @xiaolong-666! I've left a comment below for you to review.

@xiaolong-666 this page is very nicely written! Instead of parenthetically putting the flags in the example descriptions, please remove those and change the short flags to long flags in the commands, including the ones for ssh.

For example -azvhP should be --archive --compress --verbose --human-readable --partial --progress.

pages.zh/common/rsync.md Outdated Show resolved Hide resolved
@sbrl
Copy link
Member

sbrl commented Jan 31, 2021

@bl-ue: regarding rsync's short arguments, we're tried to offset that with the description in english:

- Transfer file in [a]rchive (to preserve attributes) and compressed ([z]ipped) mode with [v]erbose and [h]uman-readable [P]rogress

...obiously, this syntax doesn't translate into other languages though, which is rather awkward. But in this particular instance expanding on all the short arguments would result in an extremely long command which should be difficult to type, so I'm not sure.

@bl-ue
Copy link
Contributor

bl-ue commented Jan 31, 2021

Then maybe we should remove some of the options entirely. I think it would be best to use long options and save description space for something else.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xiaolong-666, it looks like you missed some periods...

pages.zh/common/rsync.md Outdated Show resolved Hide resolved
pages.zh/common/rsync.md Outdated Show resolved Hide resolved
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you delete a necessary newline—maybe you were confused by @navarroaxel's comment? Apply my suggestion below to fix it.

pages.zh/common/rsync.md Show resolved Hide resolved
xiaolong-666 and others added 2 commits February 2, 2021 09:06
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@bl-ue
Copy link
Contributor

bl-ue commented Feb 2, 2021

Darn, now it looks like there's two newlines...let me take a look...

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There we go. LGTM!

@bl-ue bl-ue requested a review from navarroaxel February 2, 2021 02:51
@xiaolong-666
Copy link
Contributor Author

@bl-ue This format detection is not smart... ha ha

@navarroaxel navarroaxel changed the title rsync: add Chinese (zh) translation rsync: add Chinese translation Feb 2, 2021
@navarroaxel navarroaxel merged commit d698531 into tldr-pages:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants