-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsync: add Chinese translation #5200
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the page @xiaolong-666! I've left a comment below for you to review.
@xiaolong-666 this page is very nicely written! Instead of parenthetically putting the flags in the example descriptions, please remove those and change the short flags to long flags in the commands, including the ones for ssh
.
For example -azvhP
should be --archive --compress --verbose --human-readable --partial --progress
.
@bl-ue: regarding - Transfer file in [a]rchive (to preserve attributes) and compressed ([z]ipped) mode with [v]erbose and [h]uman-readable [P]rogress ...obiously, this syntax doesn't translate into other languages though, which is rather awkward. But in this particular instance expanding on all the short arguments would result in an extremely long command which should be difficult to type, so I'm not sure. |
Then maybe we should remove some of the options entirely. I think it would be best to use long options and save description space for something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xiaolong-666, it looks like you missed some periods...
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you delete a necessary newline—maybe you were confused by @navarroaxel's comment? Apply my suggestion below to fix it.
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Darn, now it looks like there's two newlines...let me take a look... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There we go. LGTM!
@bl-ue This format detection is not smart... ha ha |
common/
,linux/
, etc.)