-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test, [: add page, improve examples #5205
Conversation
This comment has been minimized.
This comment has been minimized.
Hey @Rudloff! Wow, this is crazy one...sort of duplicate of another page, also it's name is strange...we should update the linter to allow In general, I don't really know what we should do about it, so I'll ask the others who are much more familiar than I am. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page, @Rudloff! I've left some comments below for you to review.
@bl-ue: This is a perfectly legit page :P
This isn't even a shell builtin like shopt
(which we also have documented) - try executing which [
.
If the linter isn't configured to like this, it should be. It's this kinda command that means linting command names or filenames is rather a challenge :P
Cool @sbrl. These changes should also be ported to https://github.com/tldr-pages/tldr/blob/master/pages/common/test.md. That page is actually so old (1/8/2016!) and it should be updated in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Rudloff now every description and every command has a suggestion 😂
Well, the page this was based on, test.md
, is actually really old. It was added in 2015 and modified only once since.
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
We shouldn't merge this though. The title should be changed to |
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Was the linter updated? I can't remember. There's also the lowercase filenames change that was merged into the linter recently too, so caution is probably advised. |
@sbrl your PR tldr-pages/tldr-lint#44 is waiting for you 😉 |
Thanks, @bl-ue! I've updated there & run jison. I've been busy with life stuff, so haven't had much time for tldr-pages recently :-/ |
Hi all! This thread has not had any recent activity. |
I'll release a new version of |
@owenvoke That would be great! Don't worry about the delay. You're not the only one ;) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rudloff!
This PR broke fish shell autocompletion in tldr-pages/tldr-c-client. |
common/
,linux/
, etc.)The examples are reused from
test.md
.tldr-lint
would not let me use[
as the page title.