deps: update deps

[bl-ue]

• glob — 7.1.3 → 7.1.6
• husky — 2.2.0 → 6.0.0
• markdownlint-cli — 0.19.0 → 0.27.1

[bl-ue]

We should enable Dependabot on this repo, like we do in the node client's repo.

[owenvoke]

LGTM! I agree about enabling Dependabot. Feel free to do that if you want (or I can if you'd like?). I'd suggest going with weekly updates to reduce the number of PRs we'd get from it.

[bl-ue]

Will you please do it? I'm not an org owner (yet), so I can't edit the repository in that type of way.

[bl-ue]

We should probably do it after this PR is merged though, because it might open duplicate PRs :)

[bl-ue]

Please see the latest commit. I ran npx husky-4-to-5 to convert the old format to the new one.

[bl-ue]

Hmm...npm ci is failing locally as well as in the CI!

[bl-ue]

Not sure what changed to cause this error, but I fixed it by adding the name key to package.json. The full error was:

TypeError: Cannot read property 'length' of undefined
    at _incorrectWorkingDirectory (~/.npm/node_modules/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:114:60)
    at ~/.npm/node_modules/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:86:44
    at ~/.npm/node_modules/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:218:12
    at callback (~/.npm/node_modules/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:295:20)
    at FSReqCallback.oncomplete (fs.js:165:5)

the code at that path (npm-lifecycle/index.js:114:60):

function _incorrectWorkingDirectory (wd, pkg) {
  return wd.lastIndexOf(pkg.name) !== wd.length - pkg.name.length
}

after a console.log(pkg), I found it to be the parsed contents of package.json.

So, I added name. It really should've always been there, because package.json isn't much of a real package.json otherwise. It also needs version, because npm displays the package as tldr-pages@undefined 😄, coincides with #5377 (comment).

[mebeim]

Is the new .husky/pre-commit file required for Husky v5? Just want to make sure.

[bl-ue]

Yes, it is. You can see they have one, here. Also, I used this package to convert from version 2 to 5. It created a .gitignore and added some items, but it didn't add that, I'd say on purpose.

[sbrl]

Looks ok to me

What's husky, out of curiosity? Something that our GitHub Actions uses?

[navarroaxel]

What's husky, out of curiosity? Something that our GitHub Actions uses?

@sbrl an easy wrapper to run hooks like eslint before pre-commit or pre-push, etc. Without deal with bash files in the .git/hooks directory. Just config in the package.json.

[bl-ue]

I just updated husky 5.1.3 → 5.2.0, and I upgraded the lockfile format from v1 (npm 6 and lower) to v2 (npm 7) as it's quickly becoming the norm (and we're already using it in the linter).

[bl-ue]

@owenvoke are we ready to merge?

[Waples]

guess i'll bump @owenvoke

[bl-ue]

Actually, they just released husky 6.0.0 so I need to make the change...