Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homectl: add page #5688

Merged
merged 6 commits into from
Apr 13, 2021
Merged

homectl: add page #5688

merged 6 commits into from
Apr 13, 2021

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Apr 4, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel requested a review from bl-ue April 4, 2021 19:38
@tansiret tansiret self-requested a review April 7, 2021 07:21
@Waples
Copy link
Member

Waples commented Apr 7, 2021

lgtm

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @navarroaxel! Just a few minor comments.

In general systemd homed looks very concerning indeed in that it performs a number of functions it really shouldn't - I'd suggest that this command is falsely named in that it's more of a user account management command as opposed to a home directory management command.

Regardless, documenting it is a valuable exercise as it ensures those who are unlucky enough to find themselves on the receiving end of a system with systemd-homed installed are able to quickly understand how to administrate the system.

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel merged commit 660d097 into master Apr 13, 2021
@navarroaxel navarroaxel deleted the pages/homectl branch April 13, 2021 13:35
@acuteenvy acuteenvy mentioned this pull request May 13, 2023
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants