MAINTAINERS: add @Waples to collaborators #5775
Conversation
| @@ -60,6 +62,7 @@ If you are an owner of the organization, you should be able to see an automated | |||
| - Matthew Peveler ([@MasterOdin](https://github.com/MasterOdin)): | |||
| [09 January 2021](https://github.com/tldr-pages/tldr/issues/5122) — [01 April 2021](https://github.com/tldr-pages/tldr/issues/5473) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
why the double enter?
There was a problem hiding this comment.
Yeah, let's clear that out @Waples:
There was a problem hiding this comment.
Everywhere else in the markdown document has double breaks between , why not here?
There was a problem hiding this comment.
Owh nevermind, I had a diff left over where I fixed all those double breaks. Want me to fix that or remove this ?
There was a problem hiding this comment.
Oh, send the fix in another PR 🤷♂️
There was a problem hiding this comment.
I would've preferred that we fixed this here, because I see no reason for a newline being added where it was 🤔
@Waples will you please open a PR to fix this?
There was a problem hiding this comment.
I trusted too much in this comment #5775 (comment) my fault.
There was a problem hiding this comment.
Don't worry, it's no problem. I think @Waples made a mistake because there were actually no double line-breaks in the file before this PR.
navarroaxel
changed the title
navarroaxel
added
the
community
|
Oh, you should rebase with the |
bl-ue
force-pushed
the
update-MAINTAINERS.md
branch
from
7b59ffc to
2825686
Compare
|
I rebased and fixed it. @Waples the problem was that you forgot to update your fork's |
There was a problem hiding this comment.
Besides https://github.com/tldr-pages/tldr/pull/5775/files#r615005556, LGTM!
Welcome aboard, @Waples!! 🎆
Also, I noticed that your commit was made at exactly 16:00:00 UTC (6 PM your time) — is that intentional? 😄
|
@bl-ue not intentional, but good for stats I suppose |
Closes #5774