-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upower: add page #5923
upower: add page #5923
Conversation
Sorry, but the cla needs my private email. Who will be able to see that and where will it be listed (eg a contributors file somewhere) |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
I am perfectly happy to sign the license agreement however I am not willing to give my private email to it |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@CleanMachine1 None of us have access to your email. I'm not sure what cla-assistant.io does with it, but they certainly keep it private (I don't think any human has access to it on any side). |
Is it mandatory for it to be done? |
Yes, it is, for legal reasons 😞 There's absoluately no danger of your email being exposed though! |
@CleanMachine1 you could however use another email for your commits and add it to your GitHub account. |
Unfortunately not... Also I already use the githubnoreply for commits I am currently migrating my account so I will have agreed to it in a day or 2 |
Don't close this PR and I will have it signed or whatever in the next 24 hours (probably) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
Read up and see! Good to here its alright though |
Had a free hour, all is done and signed @nicokosi |
Do you know if I can remove CLA assistant from my account after this is merged? |
Do you mean unsign the CLA? |
No, remove it from my OAuth applications list, revoking access from my private email |
Ah yes, I'm sure you can do that. But you'll need to do it all over again if you want to open another PR... 😄 |
Ok, well considering it took me 20 seconds to think of topic to cover, I will find another command I use which isn't here. Overall been enjoying this repo, been using it for around a week. I often encrypt single files and the command is gpg -c file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole command isn't just about the battery, but about power in general (including line power, the display, etc.), so I would replace battery
with power
everywhere.
Can collab leave reviews, like what you have done. I like the sound of playing a role in helping! |
They do. You can also make reviews now, it just doesn't affect the merge status if you approve or request changes. |
Which status do you have to be to make status changes with reviews. |
Collaborator or organization member. All you need is write access to the repo, which both roles have. Btw, I'm preparing a reply for you, so be patient ;P |
Ok, I don't know what you are replying to however I look forward to whatever it may be. |
That's not true, exactly. @marchersimon opened issues to discuss whether or not we should remove them, but they're They were interested in the repo at various times over the years, so they were invited as collaborators, to make it easier for them to contribute. As with everyone though, their interests shifted onto other things, so they became less and less active. It's been a while, so they aren't helping out with the maintenance tasks nor contributing pages, so @marchersimon wants to remove them, not as a demotion or punishment or anything of the sort, but as a reflection of their actual involvement in the project :)
Not hard at all! Usually, when we see someone contributor several pages (5 is the minimum per
❤️
That would be fantastic! Contribution of any kind from any contributor is desired, as this is a community volunteer-based project (i.e. the maintainers were and are just
Any user with a GitHub account can leave reviews on any PR in any public repository. They can comment, suggest code changes, etc. Really, you don't even need to be a collaborator to help out with tldr-pages. But collaborators and organization members/owners (both roles have write access to the repo) can label and close issues/PRs, and merge PRs, in addition to the common things that every user can do.
😍 That would be amazing! Please, open a few more PRs with some nice, high-quality pages (and maybe help out fix a few existing open PRs) and you'll be elligible in no time. |
Well the reason I am so interested is I (for some reason) like to make documentation. I don't expect to gain collab or anything similar from these commits however it would be nice 😄 Expect me to keep following this, even if I stop for a week, continue to ping me with review requests as I will happily do them ASAP. |
Some things to check out if you want to:
|
I didn't think of that! I see you guys have opened some issues there, and I'll watch that repo, too. |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Push? |
I'm waiting for @marchersimon 's response to my question about the more information link. |
@Waples review? |
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
No need to be so impatient @CleanMachine1. |
Not trying to be impatient, sorry about that. Just sending you a notification that your input is wanted |
Hey @CleanMachine1 join us in our https://gitter.im/tldr-pages/tldr channel |
say hi! 😄 |
common/
,linux/
, etc.)