Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-authors: add page #5951

Merged
merged 22 commits into from
May 18, 2021
Merged

git-authors: add page #5951

merged 22 commits into from
May 18, 2021

Conversation

CleanMachine1
Copy link
Member

@CleanMachine1 CleanMachine1 commented May 12, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-authors.md:6 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Display log of authors/commi..."]
pages/common/git-authors.md:6: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label May 12, 2021
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@bl-ue bl-ue mentioned this pull request May 12, 2021
73 tasks
@CleanMachine1
Copy link
Member Author

Take a look now and give another review, I feel this is how it should be.

Also the the usage of display and print is used since the display to me indicates that it isn't a firm output, rather something that can be scrolled through, while the print is used to indicate that it just dumps the entire lot, as if it was concatenated using cat

pages/common/git-authors.md Outdated Show resolved Hide resolved
CleanMachine1 and others added 4 commits May 12, 2021 21:09
@CleanMachine1
Copy link
Member Author

@navarroaxel @marchersimon @bl-ue Please take a look at this PR and give your thoughts so we can work on getting it merged

pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
CleanMachine1 and others added 4 commits May 13, 2021 22:22
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
pages/common/git-authors.md Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
@CleanMachine1 CleanMachine1 requested a review from bl-ue May 17, 2021 18:37
@CleanMachine1
Copy link
Member Author

@bl-ue @navarroaxel This is ready for review

pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Outdated Show resolved Hide resolved
CleanMachine1 and others added 2 commits May 18, 2021 11:54
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@bl-ue bl-ue requested a review from navarroaxel May 18, 2021 11:42
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/common/git-authors.md Outdated Show resolved Hide resolved
pages/common/git-authors.md Show resolved Hide resolved
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@CleanMachine1 CleanMachine1 merged commit 440330b into tldr-pages:main May 18, 2021
@CleanMachine1 CleanMachine1 deleted the git-authors-addpage branch May 18, 2021 18:30
@sbrl
Copy link
Member

sbrl commented May 18, 2021

Erm why did you merge this @CleanMachine1? Just because you disagree with one of my comments doesn't mean that you can merge it without letting me reply.

@CleanMachine1
Copy link
Member Author

Sorry about that, however it seemed that simon agreed with my original wording and bl-ue didn't mind.
Sorry, didn't mean for any harm or wrong doing

@sbrl
Copy link
Member

sbrl commented May 18, 2021

Next time, if someone disagrees with something wait until they reply and everyone is in agreement before merging @CleanMachine1 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants