-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-authors: add page #5951
git-authors: add page #5951
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Take a look now and give another review, I feel this is how it should be. Also the the usage of display and print is used since the display to me indicates that it isn't a firm output, rather something that can be scrolled through, while the print is used to indicate that it just dumps the entire lot, as if it was concatenated using cat |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel @marchersimon @bl-ue Please take a look at this PR and give your thoughts so we can work on getting it merged |
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@bl-ue @navarroaxel This is ready for review |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page! I've left some comments below for you to review.
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Erm why did you merge this @CleanMachine1? Just because you disagree with one of my comments doesn't mean that you can merge it without letting me reply. |
Sorry about that, however it seemed that simon agreed with my original wording and bl-ue didn't mind. |
Next time, if someone disagrees with something wait until they reply and everyone is in agreement before merging @CleanMachine1 :-) |
common/
,linux/
, etc.)For #5137