Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-local-commits: add page #5981

Merged
merged 4 commits into from
May 20, 2021
Merged

git-local-commits: add page #5981

merged 4 commits into from
May 20, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

@CleanMachine1 CleanMachine1 mentioned this pull request May 17, 2021
Closed
73 tasks
@CleanMachine1 CleanMachine1 added community Issues/PRs dealing with role changes and community organization. new command Issues requesting creation of a new page. and removed community Issues/PRs dealing with role changes and community organization. labels May 17, 2021
bl-ue
bl-ue approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pages/common/git-local-commits.md Outdated Show resolved Hide resolved
@CleanMachine1 @bl-ue
Changed description of git-local-commits to tell user what will happe…
5ebfcf1 
…n if they enter anything else

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@bl-ue bl-ue requested a review from nicokosi May 18, 2021 15:05
@CleanMachine1 @bl-ue
Update pages/common/git-local-commits.md
ac3c92c 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
marchersimon
marchersimon approved these changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CleanMachine1
Copy link
Member Author

Can I merge?

@marchersimon
Copy link
Collaborator

Maybe we should wait for @nicokosi's approval, since they requested changes.

@CleanMachine1
Copy link
Member Author

Give it another 2 days then i am merging, is that ok?

In the meantime @nicokosi you are wanted here! 😄

nicokosi
nicokosi approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@nicokosi nicokosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CleanMachine1 CleanMachine1 merged commit 3d70909 into main May 20, 2021
@CleanMachine1 CleanMachine1 deleted the git-local-comits branch May 20, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@nicokosi nicokosi nicokosi approved these changes

@marchersimon marchersimon marchersimon approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CleanMachine1 @marchersimon @nicokosi @bl-ue