Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-delta: add page #6010

Merged
merged 6 commits into from
May 21, 2021
Merged

git-delta: add page #6010

merged 6 commits into from
May 21, 2021

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented May 21, 2021

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For: #5137

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@tldr-bot

This comment has been minimized.

@CleanMachine1
Copy link
Member

CleanMachine1 commented May 21, 2021

Had to edit your comment since you link an issue which I don't want closed

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label May 21, 2021
pages/common/git-delta.md Outdated Show resolved Hide resolved
@CleanMachine1 CleanMachine1 mentioned this pull request May 21, 2021
73 tasks
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@tldr-bot

This comment has been minimized.

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@tldr-bot

This comment has been minimized.

@bl-ue
Copy link
Contributor

bl-ue commented May 21, 2021

@mfrw In case you didn't know, @CleanMachine1 and I are new members on the team :) @CleanMachine1 has been here since last week, I've been here since January.

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@tldr-bot

This comment has been minimized.

@mfrw
Copy link
Member Author

mfrw commented May 21, 2021

@mfrw In case you didn't know, @CleanMachine1 and I are new members on the team :) @CleanMachine1 has been here since last week, I've been here since January.

@bl-ue Thank you for informing me. I knew about you. I guess i am a bit rusty after a long time, hopefully will get better :)
@CleanMachine1 how is the experience!

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@bl-ue
Copy link
Contributor

bl-ue commented May 21, 2021

I guess i am a bit rusty after a long time

@mfrw Completely understand, I can barely submit a page that isn't littered with typos and other detritus 😆

@mfrw
Copy link
Member Author

mfrw commented May 21, 2021

I guess i am a bit rusty after a long time

@mfrw Completely understand, I can barely submit a page that isn't littered with typos and other detritus 😆

Got the issue, my editor has a lot of plugins which try to do a lot of stuff... disabled them for now :)

@CleanMachine1
Copy link
Member

When we merge I would like to be left as a co-author since I added an example

@mfrw
Copy link
Member Author

mfrw commented May 21, 2021

When we merge I would like to be left as a co-author since I added an example

ofcourse .. i guess that goes without saying.

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mfrw

@mfrw mfrw merged commit 82fccf7 into tldr-pages:main May 21, 2021
@mfrw mfrw deleted the git-extras/delta branch May 21, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants