Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-fork: add page #6013

Merged
merged 7 commits into from
May 23, 2021
Merged

git-fork: add page #6013

merged 7 commits into from
May 23, 2021

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented May 21, 2021

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For: #5137

@mfrw
git-fork: add page
fa7e8fc 
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw mfrw added the new command Issues requesting creation of a new page. label May 21, 2021
@CleanMachine1 CleanMachine1 mentioned this pull request May 21, 2021
Closed
73 tasks
bl-ue
bl-ue suggested changes May 21, 2021
View reviewed changes
pages/common/git-fork.md Outdated Show resolved Hide resolved
pages/common/git-fork.md Outdated Show resolved Hide resolved
pages/common/git-fork.md Outdated Show resolved Hide resolved
marchersimon
marchersimon reviewed May 21, 2021
View reviewed changes
pages/common/git-fork.md Outdated Show resolved Hide resolved
pages/common/git-fork.md Outdated Show resolved Hide resolved
pages/common/git-fork.md Outdated Show resolved Hide resolved
@bl-ue
Copy link
Contributor

bl-ue commented May 21, 2021

@marchersimon I just submitted some suggestions right before you did 😂

@marchersimon
Copy link
Collaborator

I just saw it, we'll find some way to merge them 😄

@marchersimon
Copy link
Collaborator

Best, we just let @mfrw decide, since it's their review.

mfrw and others added 3 commits May 22, 2021 02:16
@mfrw @bl-ue
Update pages/common/git-fork.md
3a1ddb1 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@mfrw @bl-ue
Update pages/common/git-fork.md
f5d2d9c 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@mfrw @marchersimon
Update pages/common/git-fork.md
270b70c 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@mfrw @SethFalco
Update pages/common/git-fork.md
6bef78b 
Co-authored-by: Seth Falco <seth@falco.fun>
@CLAassistant
Copy link

CLAassistant commented May 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mfrw mfrw force-pushed the git-extras/fork branch 2 times, most recently from 4f0fe98 to 413e480 Compare May 22, 2021 15:30
@mfrw
git-fork: use 'slug' instead of short-name
d27d6bf 
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw @SethFalco
Update pages/common/git-fork.md
54ccd21 
Co-authored-by: Seth Falco <seth@falco.fun>
@mfrw mfrw merged commit 026e22a into tldr-pages:main May 23, 2021
@mfrw mfrw deleted the git-extras/fork branch May 23, 2021 13:19
@nicokosi nicokosi mentioned this pull request Jun 9, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchersimon marchersimon marchersimon left review comments

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@SethFalco SethFalco SethFalco approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mfrw @bl-ue @marchersimon @CLAassistant @SethFalco @CleanMachine1