Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-summary: add page #6065

Merged
merged 7 commits into from
Jun 7, 2021
Merged

git-summary: add page #6065

merged 7 commits into from
Jun 7, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

There is a missing option (--list) since it seems useles

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label May 28, 2021
@CleanMachine1 CleanMachine1 mentioned this pull request May 28, 2021
Closed
73 tasks
@tldr-pages tldr-pages deleted a comment from tldr-bot May 29, 2021
marchersimon
marchersimon reviewed May 29, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing option (--list) since it seems useles

I assume you mean --line. I don't think it's useless at all.

pages/common/git-summary.md Outdated Show resolved Hide resolved
pages/common/git-summary.md Outdated Show resolved Hide resolved
CleanMachine1 and others added 2 commits May 29, 2021 20:36
@CleanMachine1 @marchersimon
Update pages/common/git-summary.md
f10435f 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@CleanMachine1 @marchersimon
Update pages/common/git-summary.md
7832ac0 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
navarroaxel
navarroaxel requested changes May 30, 2021
View reviewed changes
pages/common/git-summary.md Outdated Show resolved Hide resolved
@CleanMachine1 @navarroaxel
Update pages/common/git-summary.md
23143b6 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
marchersimon
marchersimon approved these changes Jun 5, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I still think it would be a good idea to document --line too.

@CleanMachine1
Copy link
Member Author

Looks good, but I still think it would be a good idea to document --line too.

Well personally I don't see the use of it, however if you would like to, it would make the page better!

marchersimon
marchersimon reviewed Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the page isn't really long and at least a few probably will find use for it:

pages/common/git-summary.md Show resolved Hide resolved
@CleanMachine1 @marchersimon
Added the --line flag
51daa80 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
sbrl
sbrl approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CleanMachine1 and @marchersimon!

@sbrl sbrl merged commit 4272859 into main Jun 7, 2021
@sbrl sbrl deleted the git-summary branch June 7, 2021 20:03
@bl-ue bl-ue mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@marchersimon marchersimon marchersimon approved these changes

@sbrl sbrl sbrl approved these changes

@bl-ue bl-ue Awaiting requested review from bl-ue

@SethFalco SethFalco Awaiting requested review from SethFalco

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CleanMachine1 @navarroaxel @sbrl @SethFalco @marchersimon @bl-ue