-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-secretsmanager: add page #6131
Conversation
{{commit_message}} Creative 😄 |
Accidentally pasted the newline when I was pasting the command, so it took the default name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good @258204 — I have a few little comments.
Fair warning, depending on what tier you are in, a secret costs $0.40 a month. So be careful with testing. |
Yeah, AWS can get costly. But only can — a lot of services have a free tier (e.g. CodeCommit). |
Ah, you used
I recommend using the official Node.js client. It intercepts (happy to share my theme and tldr config if any wants it ;) |
I'd just like to say you could easily change the message through
pick hash {{edit message here}} However @bl-ue could you just confirm this is correct procedure |
python client does the same
I don't know if you can change the color though, I couldn't see how |
Umm, no, you need to use But, an even easier method (if the comment that you want to edit the message of is the latest one), is |
https://github.com/tldr-pages/tldr-python-client#configuration |
Thanks this is quite useful. I should have applied this. When I push to github it merges back to {{edit message here}} |
Update pages/common/aws-secretsmanager.md Co-authored-by: Axel Navarro <navarroaxel@gmail.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com> Update pages/common/aws-secretsmanager.md Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
When doing anything with commits that isn't just adding them (e.g. modifying commits, removing commits), you need to force-push The workflow would look like this: $ git rebase -i HEAD~8
pick e1a40e04 {{commit_message}}
pick 83189fe9 Update pages/common/aws-secretsmanager.md
pick 95e5d448 Update pages/common/aws-secretsmanager.md
pick b185f25f Update pages/common/aws-secretsmanager.md
pick a5791228 Update pages/common/aws-secretsmanager.md
pick 16967805 Update pages/common/aws-secretsmanager.md
pick 46657cd0 Update pages/common/aws-secretsmanager.md
pick f763d2aa Update pages/common/aws-secretsmanager.md then you change all of the
Before that, the commmits for this branch look like this:
Now, it looks like this
After you finish the rebase, and it opens the editor for you to enter your reword, it opens the editor again, this time to edit the message for the squashed commit. I chose to leave all of the commits' messages in the final commit, but you don't have to if you don't want to. You can do all of this right now, if you'd like. The page will stay intact 🙂 (if you mess anything up, I've got both versions of the branches locally for backup ;) |
f763d2a
to
d566b8b
Compare
Thank you so much :D. This clearer than all the other instructions for re-basing I could find. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
whoa, lot of conflicts there. Need help fixing them? |
yes please |
This gives new meaning to the term spagetti code. |
d566b8b
to
9829482
Compare
Done — looks like you just had some merge conflict due to forgetting to push/pull/force-push or something on that score. |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
common/
,linux/
, etc.)For #5653