Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-login: add page #6137

Merged
merged 9 commits into from
Jun 23, 2021
Merged

docker-login: add page #6137

merged 9 commits into from
Jun 23, 2021

Conversation

258204
Copy link
Collaborator

@258204 258204 commented Jun 17, 2021 •
edited by bl-ue
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Jun 17, 2021
258204 and others added 2 commits June 19, 2021 01:13
@258204 @navarroaxel
Update pages/common/docker-login.md
f663ecc 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@258204 @CleanMachine1
Update pages/common/docker-login.md
15656b4 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
navarroaxel
navarroaxel requested changes Jun 18, 2021
View reviewed changes
pages/common/docker-login.md Outdated Show resolved Hide resolved
258204 and others added 2 commits June 19, 2021 08:25
@258204 @navarroaxel
Update pages/common/docker-login.md
8e6858b 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@258204 @navarroaxel
Update pages/common/docker-login.md
0c5cf6b 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@258204
Copy link
Collaborator Author

258204 commented Jun 18, 2021

@navarroaxel Were your suggested changes implemented? I applied all your changes, yet "1 change requested" is still visible.

marchersimon
marchersimon requested changes Jun 19, 2021
View reviewed changes
pages/common/docker-login.md Outdated Show resolved Hide resolved
pages/common/docker-login.md Outdated Show resolved Hide resolved
pages/common/docker-login.md Outdated Show resolved Hide resolved
pages/common/docker-login.md Outdated Show resolved Hide resolved
pages/common/docker-login.md Show resolved Hide resolved
@bl-ue
Copy link
Contributor

bl-ue commented Jun 19, 2021

@navarroaxel Were your suggested changes implemented? I applied all your changes, yet "1 change requested" is still visible.

@258204 the persons who reject changes need to approve afterwards, or another collaborator needs to dismiss them, in order for that to go away.

@navarroaxel navarroaxel requested a review from bl-ue June 19, 2021 13:12
@258204
Copy link
Collaborator Author

258204 commented Jun 19, 2021

@navarroaxel Were your suggested changes implemented? I applied all your changes, yet "1 change requested" is still visible.

@258204 the persons who reject changes need to approve afterwards, or another collaborator needs to dismiss them, in order for that to go away.

I thought I had accepted all of them though.

258204 and others added 4 commits June 20, 2021 03:17
@258204 @marchersimon
Update pages/common/docker-login.md
49fa22d 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@258204 @marchersimon
Update pages/common/docker-login.md
373c388 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@258204 @marchersimon
Update pages/common/docker-login.md
ec833d4 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@258204 @marchersimon
Update pages/common/docker-login.md
45a9094 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@258204 258204 requested a review from marchersimon June 20, 2021 16:12
marchersimon
marchersimon approved these changes Jun 20, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

CleanMachine1
CleanMachine1 approved these changes Jun 20, 2021
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marchersimon marchersimon merged commit 6f1cd48 into tldr-pages:main Jun 23, 2021
@navarroaxel navarroaxel mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@marchersimon marchersimon marchersimon approved these changes

@bl-ue bl-ue bl-ue approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@258204 @bl-ue @navarroaxel @marchersimon @CleanMachine1