sdcv: add page #6145

258204 · 2021-06-20T01:37:48Z

The page (if new), does not already exist in the repo.
The page is in the correct platform directory (common/, linux/, etc.)
The page has 8 or fewer examples.
The PR title conforms to the recommended templates.
The page follows the content guidelines.
The page description includes a link to documentation or a homepage (if applicable).

258204 · 2021-06-20T01:47:48Z

The --json option isn't working properly, but -j is, which is why I didn't use --json.

I don't have the slightest Idea how this got here....

pages/common/sdcv.md

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>

258204 · 2021-06-20T16:11:25Z

@navarroaxel I checked and all your requested changes were implemented, yet it says there is still one change requested from you? Anything else you want changed?

pages/common/sdcv.md

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>

bl-ue

Will you please move the Display help example to the bottom (help usually goes there), and the Start sdcv interactively one to the top (simplest invocations start at the top).

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>

sbrl

Thanks for the new page! I've left some comments below for you to review.

sbrl · 2021-06-20T21:06:51Z

pages/common/sdcv.md

+> StarDict console version. Command line dictionary client.
+> Dictionaries are provided separately.


Perhaps this will read better?

Suggested change

> StarDict console version. Command line dictionary client.

> Dictionaries are provided separately.

> StarDict command-line dictionary client.

> Dictionaries are provided separately to the program itself.

~~Would you like to edit that to command-line~~ Edit: done by @bl-ue

I didn't see it previously

And I don't like that itself, its unrequired

I want to include"StarDict command-line version" somewhere, because that's what the acronym is.

How about "StarDict command-line version, dictionary client. Dictionaries are provided separately from the client. "

Ah, that's interesting @258204. In that case I think it's fine to deviate a bit from "convention."

> StarDict command-line version (sdcv). > Dictionaries are provided separately from the program itself.

(note: @sbrl's separately to is not grammatically correct — @258204's separately from is)

Hrm, StarDict command-line version doesn't really read very well or make grammatical sense. Despite this, I think @bl-ue's suggestion is the best one given the situation.

What about

> StarDict command-line variant

Hrm. I think StarDict command-line variant is worse than @bl-ue's version.

pages/common/sdcv.md

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

258204 · 2021-06-21T00:12:19Z

There were some conflicting changes requested. I modified the file to address them. Let me know if you want any additional changes.

marchersimon

Just a few suggestions

pages/common/sdcv.md

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

pages/common/sdcv.md

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

sbrl

Thanks for sticking with the review process, @258204 :-)

258204 added 3 commits June 16, 2021 14:28

Examples for aws-cur.md

55e8ca4

Merge branch 'main' of github.com:258204/tldr into main

b7081f4

sdcv

127ca1d

This comment has been minimized.

Sign in to view

aws cur shouldn't be here

fec9f52

added --use-dict example

27ed6d9

This comment has been minimized.

Sign in to view

fixed formatting

dbc4f43

This comment has been minimized.

Sign in to view

Update sdcv.md

24f30bb

This comment has been minimized.

Sign in to view

stray text

ffb7838

I don't have the slightest Idea how this got here....

navarroaxel added the new command Issues requesting creation of a new page. label Jun 20, 2021

navarroaxel requested changes Jun 20, 2021

View reviewed changes

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

CleanMachine1 reviewed Jun 20, 2021

View reviewed changes

pages/common/sdcv.md Outdated Show resolved Hide resolved

258204 and others added 3 commits June 21, 2021 01:37

Update pages/common/sdcv.md

72c09f9

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>

Update pages/common/sdcv.md

3e816a8

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>

Update pages/common/sdcv.md

d1e3d26

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Update pages/common/sdcv.md

bbc2679

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>

This comment has been minimized.

Sign in to view

258204 requested a review from navarroaxel June 20, 2021 16:11

removed trailing whitespace

1c56580

This comment has been minimized.

Sign in to view

bl-ue suggested changes Jun 20, 2021

View reviewed changes

pages/common/sdcv.md Outdated Show resolved Hide resolved

Update pages/common/sdcv.md

50a53ca

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>

bl-ue suggested changes Jun 20, 2021

View reviewed changes

Update sdcv.md

cda109b

258204 and others added 2 commits June 21, 2021 05:21

Update pages/common/sdcv.md

e1fcc76

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>

Update pages/common/sdcv.md

494f513

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>

bl-ue approved these changes Jun 20, 2021

View reviewed changes

sbrl requested changes Jun 20, 2021

View reviewed changes

258204 and others added 5 commits June 21, 2021 09:24

Update pages/common/sdcv.md

c826094

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

Update sdcv.md

3829654

Update pages/common/sdcv.md

9580661

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

Update pages/common/sdcv.md

e799308

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

Update pages/common/sdcv.md

7a16978

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

258204 requested review from sbrl and CleanMachine1 June 21, 2021 00:12

mfrw mentioned this pull request Jun 21, 2021

avoid documenting examples related to: -h & --help #6153

Closed

removed help

233d347

CleanMachine1 approved these changes Jun 26, 2021

View reviewed changes

marchersimon reviewed Jun 29, 2021

View reviewed changes

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

258204 and others added 3 commits July 6, 2021 09:35

Update pages/common/sdcv.md

b628272

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

Update pages/common/sdcv.md

a13a8b8

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

Update pages/common/sdcv.md

7ac3bf9

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

258204 requested review from marchersimon and mfrw July 6, 2021 00:11

marchersimon reviewed Jul 6, 2021

View reviewed changes

pages/common/sdcv.md Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

pages/common/sdcv.md Outdated Show resolved Hide resolved

258204 and others added 2 commits July 8, 2021 03:02

Update pages/common/sdcv.md

489ff2e

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

Update pages/common/sdcv.md

d4d4f6f

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>

258204 requested a review from marchersimon July 7, 2021 17:34

navarroaxel approved these changes Jul 7, 2021

View reviewed changes

sbrl approved these changes Jul 7, 2021

View reviewed changes

sbrl merged commit 6b8fdbe into tldr-pages:main Jul 7, 2021

258204 deleted the sdcv branch November 28, 2021 02:48

navarroaxel mentioned this pull request Dec 10, 2021

Add collaborator: @258204 #7522

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sdcv: add page #6145

sdcv: add page #6145

258204 commented Jun 20, 2021 •

edited

Loading

This comment has been minimized.

258204 commented Jun 20, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

258204 commented Jun 20, 2021

This comment has been minimized.

bl-ue left a comment

sbrl left a comment

sbrl Jun 20, 2021 •

edited by bl-ue

Loading

CleanMachine1 Jun 20, 2021 •

edited by bl-ue

Loading

258204 Jun 20, 2021

258204 Jun 21, 2021

bl-ue Jun 21, 2021 •

edited

Loading

sbrl Jun 23, 2021

CleanMachine1 Jun 24, 2021

sbrl Jun 25, 2021

258204 commented Jun 21, 2021

marchersimon left a comment

sbrl left a comment

		> StarDict console version. Command line dictionary client.
		> Dictionaries are provided separately.

sdcv: add page #6145

sdcv: add page #6145

Conversation

258204 commented Jun 20, 2021 • edited Loading

This comment has been minimized.

258204 commented Jun 20, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

258204 commented Jun 20, 2021

This comment has been minimized.

bl-ue left a comment

Choose a reason for hiding this comment

sbrl left a comment

Choose a reason for hiding this comment

sbrl Jun 20, 2021 • edited by bl-ue Loading

Choose a reason for hiding this comment

CleanMachine1 Jun 20, 2021 • edited by bl-ue Loading

Choose a reason for hiding this comment

258204 Jun 20, 2021

Choose a reason for hiding this comment

258204 Jun 21, 2021

Choose a reason for hiding this comment

bl-ue Jun 21, 2021 • edited Loading

Choose a reason for hiding this comment

sbrl Jun 23, 2021

Choose a reason for hiding this comment

CleanMachine1 Jun 24, 2021

Choose a reason for hiding this comment

sbrl Jun 25, 2021

Choose a reason for hiding this comment

258204 commented Jun 21, 2021

marchersimon left a comment

Choose a reason for hiding this comment

sbrl left a comment

Choose a reason for hiding this comment

258204 commented Jun 20, 2021 •

edited

Loading

sbrl Jun 20, 2021 •

edited by bl-ue

Loading

CleanMachine1 Jun 20, 2021 •

edited by bl-ue

Loading

bl-ue Jun 21, 2021 •

edited

Loading