Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-reauthor: add page #6651

Merged
merged 7 commits into from
Oct 13, 2021
Merged

git-reauthor: add page #6651

merged 7 commits into from
Oct 13, 2021

Conversation

nav1s
Copy link
Contributor

@nav1s nav1s commented Oct 1, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Added git reauthor command from tj/git-extras (#5137)

  • Version of the command being documented (if known):
    6.2.0

@navarroaxel navarroaxel changed the title git-reauthor: Add page git-reauthor: add page Oct 1, 2021
@pixelcmtd pixelcmtd mentioned this pull request Oct 1, 2021
Closed
73 tasks
@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Oct 1, 2021
marchersimon
marchersimon reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Just a few suggestions below

pages/common/git-reauthor.md Outdated Show resolved Hide resolved
pages/common/git-reauthor.md Outdated Show resolved Hide resolved
pages/common/git-reauthor.md Outdated Show resolved Hide resolved
nav1s and others added 3 commits October 5, 2021 19:08
@nav1s @marchersimon
Update pages/common/git-reauthor.md
b72932a 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@nav1s @marchersimon
Update pages/common/git-reauthor.md
6fdd19b 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@nav1s @marchersimon
Update pages/common/git-reauthor.md
9a6a550 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
marchersimon
marchersimon approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nav1s

einverne
einverne approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@einverne einverne merged commit 0a51a8c into tldr-pages:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelcmtd pixelcmtd pixelcmtd left review comments

@einverne einverne einverne approved these changes

@marchersimon marchersimon marchersimon approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nav1s @einverne @pixelcmtd @marchersimon @CleanMachine1