Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvectl: add page #7484

Merged
merged 9 commits into from
Dec 5, 2021
Merged

resolvectl: add page #7484

merged 9 commits into from
Dec 5, 2021

Conversation

258204
Copy link
Collaborator

@258204 258204 commented Nov 28, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 28, 2021
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member

Good to see you contributing again!

258204 and others added 3 commits November 28, 2021 12:00
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
258204 and others added 2 commits November 28, 2021 12:16
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
pages/linux/resolvectl.md Outdated Show resolved Hide resolved
258204 and others added 2 commits November 30, 2021 08:38
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>

- Retrieve an MX record of domain:

`resolvectl --legend=no -t MX query {{domain}}`
Copy link
Collaborator

@navarroaxel navarroaxel Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer long arguments, and there are extra spaces.

Suggested change
`resolvectl --legend=no -t MX query {{domain}}`
`resolvectl --legend={{no}} --type={{MX}} query {{domain}}`

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I selected commit suggestion, yet it still says 1 change requested. Is there anything else that needs to be changed?

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me after @navarroaxel's comments have been addressed

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@258204 258204 requested a review from navarroaxel December 3, 2021 23:58
@navarroaxel navarroaxel merged commit 6ced4b1 into tldr-pages:main Dec 5, 2021
@acuteenvy acuteenvy mentioned this pull request May 13, 2023
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants