-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[[, [: add/update pages #7530
[[, [: add/update pages #7530
Conversation
- sync changes with [[ page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Co-authored-by: 258204 <71364336+258204@users.noreply.github.com>
Co-authored-by: 258204 <71364336+258204@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EmilySeville7cfg !
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
This reverts commit d95b657.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @EmilySeville7cfg!
Escape every tldr page name to prevent fish syntax errors. This fixes the problem in which special characters in fish were not escaped when fish shell completion was added in tldr-pages#17, because at the time none of the pages in <https://github.com/tldr-pages/tldr> had names that were syntactically special in fish. This meant that escaping was unnecessary. However, as a result of <tldr-pages/tldr#7530>, which added the files `[.md` and `[[.md`, the fish shell autocompletion will now cause a syntax error in fish whenever autocompletion triggers. This syntax error fills stderr with long error messages and prevents the fish autocompletion from running. This problem is fixed by escaping characters like `[`, which is done in this commit. See also: <tldr-pages/tldr#7530>, tldr-pages#17
common/
,linux/
, etc.)Version of the command being documented (if known):