Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[, [: add/update pages #7530

Merged
merged 15 commits into from Dec 21, 2021
Merged

[[, [: add/update pages #7530

merged 15 commits into from Dec 21, 2021

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

EmilySeville7cfg added 3 commits December 12, 2021 05:55
@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Dec 11, 2021
@258204 258204 added the mass changes Changes that affect multiple pages. label Dec 11, 2021
Copy link
Collaborator

@258204 258204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

pages/common/[.md Outdated Show resolved Hide resolved
pages/common/[[.md Outdated Show resolved Hide resolved
pages/common/[.md Outdated Show resolved Hide resolved
pages/common/[.md Outdated Show resolved Hide resolved
pages/common/[[.md Outdated Show resolved Hide resolved
pages/common/[[.md Outdated Show resolved Hide resolved
pages/common/[[.md Outdated Show resolved Hide resolved
pages/common/[[.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@258204 258204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EmilySeville7cfg !

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/[[.md:0: TLDR019 Page should only include a maximum of 8 examples

Please fix the error(s) and push again.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EmilySeville7cfg!

@sbrl sbrl merged commit 8d8634b into tldr-pages:main Dec 21, 2021
@EmilyGraceSeville7cf EmilyGraceSeville7cf self-assigned this Jan 19, 2022
superatomic added a commit to superatomic/tldr-c-client that referenced this pull request May 1, 2022
Escape every tldr page name to prevent fish syntax errors.

This fixes the problem in which special characters in fish were not
escaped when fish shell completion was added in tldr-pages#17, because at the time
none of the pages in <https://github.com/tldr-pages/tldr> had names that
were syntactically special in fish. This meant that escaping was
unnecessary.

However, as a result of <tldr-pages/tldr#7530>,
which added the files `[.md` and `[[.md`, the fish shell autocompletion
will now cause a syntax error in fish whenever autocompletion triggers.

This syntax error fills stderr with long error messages and prevents the
fish autocompletion from running. This problem is fixed by escaping
characters like `[`, which is done in this commit.

See also: <tldr-pages/tldr#7530>, tldr-pages#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants