Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chafa: add page #8413

Merged
merged 7 commits into from
Aug 29, 2022
Merged

chafa: add page #8413

merged 7 commits into from
Aug 29, 2022

Conversation

CairnThePerson
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 1.12.3

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Aug 28, 2022
navarroaxel
navarroaxel reviewed Aug 28, 2022
View reviewed changes
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
@CairnThePerson
Copy link
Collaborator Author

@navarroaxel I reworked the descriptions using a common verb ("render") throughout, and I hope I resolved the issues you had with it. Let me know what you think! 🙂

CleanMachine1
CleanMachine1 reviewed Aug 28, 2022
View reviewed changes
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
pages/common/chafa.md Outdated Show resolved Hide resolved
CairnThePerson and others added 3 commits August 28, 2022 19:06
@CairnThePerson @CleanMachine1
Simplify a description
43c177e 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@CairnThePerson @CleanMachine1
Change braille capitalization
292bfb8 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@CairnThePerson
Remove GIF distinction
56a7d58
CleanMachine1
CleanMachine1 approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks!

@kbdharun kbdharun merged commit 5ab335d into tldr-pages:main Aug 29, 2022
@CairnThePerson CairnThePerson deleted the chafa branch August 29, 2022 15:10
@CleanMachine1 CleanMachine1 mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel left review comments

@kbdharun kbdharun kbdharun approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CairnThePerson @navarroaxel @kbdharun @CleanMachine1