Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-gh-pages: add page #8787

Merged
merged 6 commits into from
Oct 10, 2022
Merged

git-gh-pages: add page #8787

merged 6 commits into from
Oct 10, 2022

Conversation

TcPirate1
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 7, 2022
@tldr-bot

This comment was marked as outdated.

Sign in to view
@kbdharun
Copy link
Member

kbdharun commented Oct 7, 2022

Hello,
Welcome to tldr. Please sign the CLA in the above comment.

@kbdharun kbdharun mentioned this pull request Oct 7, 2022
Closed
73 tasks
@TcPirate1 TcPirate1 closed this Oct 8, 2022
@TcPirate1 TcPirate1 reopened this Oct 8, 2022
@tldr-bot

This comment was marked as outdated.

Sign in to view
TcPirate1 and others added 2 commits October 8, 2022 20:28
@TcPirate1 @kbdharun
Update pages/common/git-gh-pages.md
56644b3 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@TcPirate1 @kbdharun
Update pages/common/git-gh-pages.md
41574f4 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@tldr-bot

This comment was marked as outdated.

Sign in to view
@tldr-bot

This comment was marked as outdated.

Sign in to view
@TcPirate1
Copy link
Contributor Author

Hello, Welcome to tldr. Please sign the CLA in the above comment.

Thank you!
I thought I had signed it but I must of forgotten to 😅

@TcPirate1
Update git-gh-pages.md
6a1179a 
Changed wording based on tldr bot suggestion (Creates --> Create).
@TcPirate1
Update git-gh-pages.md
fae6f8a
@TcPirate1 @navarroaxel
Update pages/common/git-gh-pages.md
289d217 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
kbdharun
kbdharun approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@navarroaxel navarroaxel merged commit fcac00d into tldr-pages:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TcPirate1 @CLAassistant @tldr-bot @kbdharun @navarroaxel