Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions #9898

kbdharun · 2023-02-27T08:24:42Z

Changes

Update Gitter Links to Matrix.
Discussion: here

SethFalco · 2023-02-27T08:29:11Z

My understanding was that we wanted to link directly to Element, i.e.

https://app.element.io/#/room/#tldr-pages:matrix.org

To simplify the experience for users that don't know what Matrix, and to make it easy to join the chat without having to make decisions like what client to use.

By using Element, users are able to sign-up, sign-in, and if they already have a Matrix account they can specify the home-server and login. Unlike on Gitter where if one is already on Matrix, that would make them essentially create a new account without the option to use their existing one.

Reference: https://matrix.to/#/!zXiOpjSkFTvtMpsenJ:gitter.im/$7cbPucUQDlK4Gz5upQ7To2IAGU_pos3N74K_B0-UhVg?via=gitter.im&via=matrix.org&via=one.ems.host

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

.github/ISSUE_TEMPLATE/config.yml

waldyrious · 2023-02-27T15:48:59Z

.github/ISSUE_TEMPLATE/config.yml

- url: https://matrix.to/#/#tldr-pages:matrix.org
- about: Matrix view of our Gitter chat rooms
+ url: https://matrix.to/#/#tldr-pages-project:matrix.org
+ about: Matrix space of our chat rooms


I'm wondering if we should avoid referring people to the space, as that's a slightly confusing aspect of Matrix still, and not very useful in the context of issue creation anyway. Maybe we should just drop this link. That would have the added benefit of making having one fewer link in the issue creation menu, which is always a benefit with this sort of intermediate step where people are just trying to get things done.

Yeah, that seems better I applied the changes, let's see what others think too.

If we want to allow others to chime in, we shouldn't mark the conversation as resolved :)

If we want to allow others to chime in, we shouldn't mark the conversation as resolved :)

Agreed, seems like I forgot to unresolved it.

I personally don't see the issue with spaces myself.
It's similar to workspaces on Slack, or servers/guilds on Discord. A fairly well-known concept.

While Matrix does this a bit differently from other platforms, the surface-level UX should be familiar.

However, in the end it makes little difference while we don't have many rooms I guess. So whatever works. 😅

So whatever works. 😅

Yeah

waldyrious · 2023-02-27T15:55:18Z

.github/ISSUE_TEMPLATE/config.yml

- - name: Gitter chat
- url: https://gitter.im/tldr-pages/tldr
+ - name: Chatroom
+ url: https://matrix.to/#/#tldr-pages:matrix.org
 about: You can ask and answer questions here


Maybe something more relevant to the issue creation flow?

Suggested change

about: You can ask and answer questions here

about: Consider joining the chat room to discuss your issue, question or suggestion with the community before opening an issue.

(Note: I didn't mull over this wording a lot, it's just a quick suggestion to get the ball rolling.)

Seems good to me

Let's keep this conversation unresolved for a while longer, so others can offer their thoughts as well.

Oxford comma!

I even wrote this a while back too. 😭
https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#serial-comma

I'm fine with adding the comma after "question" :) I don't think that in this case it would make a difference, but it doesn't hurt either.

Btw, I didn't participate in the discussion to add that section, but I wonder if it's really such a prevalent and/or contentious issue that it requires being included in the style guide... 🤔 Besides, the example given there strikes me as odd since the first ambiguous interpretation relies on usage of the comma in a place where there isn't a clause boundary (I'm sure there's a name for that — it's the opposite of a comma splice) but anyway, both of these observations are topics for a separate discussion.

Btw, I didn't participate in the discussion to add that section

I don't mind revising/scrapping it if you have reservations with it. I'm probably one of the few people that care anyway, though ofc we should include everyone anyway. ^-^'

I don't think that in this case it would make a difference

You're right, it doesn't make a difference. I just think it's nice to stick to one or the other rather do it sometimes and not other times.

This may be the wrong way to think of it, but I treat it similar to how once does curly braces in code. Either opt for the comma or don't, but doing it just sometimes is a bit shoddy.

Edit: Also, this may be subjective, but just reading it out loud, the extra comma just sounds more fitting. (Try it yourself!)

I was going to reply with a different perspective, but honestly, that's just splitting hairs at this point. Let's go with the comma, and avoid derailing this thread to much (if anything, for the sake of who may read this thread in the near or far future — as @kbdharun discovered recently, trawling through long discussions is kind of a drag 😅)

Sure sure, sorry to be a pain here though. ^-^'

Not at all, I actually had to catch myself before going on that tangent — I think it's only natural that people who are attracted to this project share this kind of attention to detail in writing :)

COMMUNITY-ROLES.md

CONTRIBUTING.md

MAINTAINERS.md

Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>

kbdharun

Updated README Badges

SethFalco · 2023-02-28T08:12:57Z

I personally prefer all lowercases badges, but that's subjective.
It's certainly more common among providers/services that offer badges of some kind, I was under the impression it was psuedo-standardized but maybe that'd be inaccurate to say. 🤔

i.e.

Shields.io
Badgen
GitLab - Only referring to the built-in badges, custom ones can ofc be uppercase
SonarQube - link is to an issue showing the badges sinces they're not shown in the docs
Gitter - Even the old Gitter badge was all lowercase by default

If you look at the top projects on GitHub, you'll find most (not all) shields/badges are in lowercase too.

i.e. look at any of the trending repos atm:

https://github.com/trending?since=monthly

Anyone else have any thoughts here?

waldyrious · 2023-02-28T09:06:44Z

I don't have strong opinions on the capitalization of the badges. I agree the lowercase convention is more prevalent, but the capitalized version doesn't look jarring to me (and in fact it may look awkward if we include the "on Matrix" suffix for the chat badge). I'm happy to heed any consensus that emerges here, though.

SethFalco · 2023-02-28T17:00:27Z

We can just run with the title cases versions. @kbdharun made the change already after all, so I think it's safe to assume they like it, and I guess it's not a big deal. Sorry to be picky!

waldyrious · 2023-03-01T08:46:40Z

Sorry to be picky!

Don't be sorry, picky people is how quality is achieved ;)

Related PR:- tldr-pages/tldr#9898

kbdharun · 2023-03-21T15:35:57Z

Hi guys, any updates on this?

Related PR:- tldr-pages/tldr#9898

Community: Update Gitter links to Matrix

61dde63

kbdharun added decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. community Issues/PRs dealing with role changes and community organization. labels Feb 27, 2023

kbdharun requested review from waldyrious, navarroaxel, SethFalco, blueskyson and CleanMachine1 February 27, 2023 08:24

github-actions bot added documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes. labels Feb 27, 2023

Update MAINTAINERS Chatroom links (2021-2013)

e0f9616

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

waldyrious reviewed Feb 27, 2023

View reviewed changes

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved

waldyrious reviewed Feb 27, 2023

View reviewed changes

COMMUNITY-ROLES.md Outdated Show resolved Hide resolved

kbdharun mentioned this pull request Feb 27, 2023

[Archive] MAINTAINERS: Gitter Chat of Old Room before Matrix bridge #9899

Closed

waldyrious reviewed Feb 27, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

kbdharun added 2 commits February 27, 2023 21:33

Update Final Gitter Links with Issue, Fix wrong date

62e40df

COMMUNITY-ROLES: add Matrix link

af16c2c

waldyrious reviewed Feb 27, 2023

View reviewed changes

MAINTAINERS.md Outdated Show resolved Hide resolved

kbdharun and others added 2 commits February 27, 2023 21:48

Remove Space in Issue template

87ea3ca

Apply suggestions from code review

8def541

Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>

kbdharun requested review from mfrw, pixelcmtd and sbrl February 27, 2023 16:34

Update MAINTAINERS.md

d58807a

kbdharun linked an issue Feb 28, 2023 that may be closed by this pull request

[Archive] MAINTAINERS: Gitter Chat of Old Room before Matrix bridge #9899

Closed

kbdharun added 2 commits February 28, 2023 12:33

Update matrix badge

7561667

CONTRIBUTING: Update matrix badge

002d5c9

README: Update badges

f593e0a

kbdharun commented Feb 28, 2023

View reviewed changes

CONTRIBUTING: Update badges

d989bb2

kbdharun changed the title ~~Community: Update Gitter links to Matrix~~ Community: Update Gitter links to Matrix, Update Badges Feb 28, 2023

kbdharun added a commit to tldr-pages/tldr-node-client that referenced this pull request Mar 11, 2023

README: Update chatroom badge to matrix

54226b4

Related PR:- tldr-pages/tldr#9898

kbdharun mentioned this pull request Mar 11, 2023

README: Update chatroom badge to matrix tldr-pages/tldr-node-client#412

Merged

README: Remove editor extensions

ac063ad

kbdharun changed the title ~~Community: Update Gitter links to Matrix, Update Badges~~ Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions Mar 11, 2023

kbdharun mentioned this pull request Mar 11, 2023

index: Update badges, highlight social channels and minor tweaks tldr-pages/tldr-pages.github.io#66

Merged

navarroaxel approved these changes Mar 12, 2023

View reviewed changes

SethFalco approved these changes Mar 25, 2023

View reviewed changes

kbdharun merged commit 46ab966 into tldr-pages:main Mar 27, 2023

kbdharun added a commit to tldr-pages/tldr-node-client that referenced this pull request Mar 27, 2023

README: Update chatroom badge to matrix (#412)

cbd617b

Related PR:- tldr-pages/tldr#9898

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions #9898

Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions #9898

kbdharun commented Feb 27, 2023 •

edited

Loading

SethFalco commented Feb 27, 2023 •

edited

Loading

waldyrious Feb 27, 2023 •

edited

Loading

kbdharun Feb 27, 2023 •

edited

Loading

waldyrious Feb 27, 2023

kbdharun Feb 27, 2023

SethFalco Feb 27, 2023

kbdharun Feb 27, 2023

waldyrious Feb 27, 2023

kbdharun Feb 27, 2023

waldyrious Feb 27, 2023 •

edited

Loading

SethFalco Feb 27, 2023

waldyrious Feb 28, 2023

SethFalco Feb 28, 2023 •

edited

Loading

waldyrious Feb 28, 2023

SethFalco Feb 28, 2023

waldyrious Mar 1, 2023

kbdharun left a comment

SethFalco commented Feb 28, 2023 •

edited

Loading

waldyrious commented Feb 28, 2023

SethFalco commented Feb 28, 2023

waldyrious commented Mar 1, 2023

kbdharun commented Mar 21, 2023

	about: You can ask and answer questions here
	about: Consider joining the chat room to discuss your issue, question or suggestion with the community before opening an issue.

Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions #9898

Community: Update Gitter links to Matrix, Update Badges, Remove editor extensions #9898

Conversation

kbdharun commented Feb 27, 2023 • edited Loading

Changes

SethFalco commented Feb 27, 2023 • edited Loading

waldyrious Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

kbdharun Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waldyrious Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SethFalco Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbdharun left a comment

Choose a reason for hiding this comment

SethFalco commented Feb 28, 2023 • edited Loading

waldyrious commented Feb 28, 2023

SethFalco commented Feb 28, 2023

waldyrious commented Mar 1, 2023

kbdharun commented Mar 21, 2023

kbdharun commented Feb 27, 2023 •

edited

Loading

SethFalco commented Feb 27, 2023 •

edited

Loading

waldyrious Feb 27, 2023 •

edited

Loading

kbdharun Feb 27, 2023 •

edited

Loading

waldyrious Feb 27, 2023 •

edited

Loading

SethFalco Feb 28, 2023 •

edited

Loading

SethFalco commented Feb 28, 2023 •

edited

Loading