Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors when loading legacy multiplayer rooms and when logged in #5396

Conversation

MitjaBezensek
Copy link
Contributor

@MitjaBezensek MitjaBezensek commented Feb 10, 2025

Is ready wrapper continued to show the spinner even after we errored out.

Change type

  • bugfix

Test plan

  1. Log in (logged out experience wasn't broken).
  2. Got to a non existing legacy room.
  3. You should see a Room not found error page.

Release notes

  • Show error pages instead of getting stuck on the spinner when logged in and visiting a legacy route.

Copy link

linear bot commented Feb 10, 2025

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Feb 10, 2025 11:58am
1 Skipped Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Feb 10, 2025 11:58am

@huppy-bot huppy-bot bot added the bugfix Bug fix label Feb 10, 2025
@MitjaBezensek MitjaBezensek requested a review from ds300 February 10, 2025 11:58
@MitjaBezensek MitjaBezensek changed the title Show errors when loading multiplayer rooms Show errors when loading legacy multiplayer rooms and when logged in Feb 10, 2025
@MitjaBezensek MitjaBezensek added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 517d808 Feb 10, 2025
14 checks passed
@MitjaBezensek MitjaBezensek deleted the mitja/int-741-not-found-ui-doesnt-show-for-rroomid-routes-any-more branch February 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants