Add an option to show estimated pitch on the spectrum. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a simple 3-Harmonic Product Spectrum. It works well when tested on my own voice (whereas Fmax often makes an octave error with the first overtone).
|
Thank you very much @celeste-sinead! I've tested it and it works well indeed. I've noticed a few things that are worth adjusting in the implementation, but I'll merge anyway and try to address those in a following commit. Thanks again for your contribution. |
tlecomte
added a commit
that referenced
this pull request
May 4, 2024
As a follow-up to #261: - add a Column to avoid overlaps between the label for the max frequency and the label for the pitch - fix the default setting value, so that the checkbox is consistent - use numpy slices instead of looping over each element, for performance
tlecomte
added a commit
that referenced
this pull request
May 4, 2024
As a follow-up to #261: - add a Column to avoid overlaps between the label for the max frequency and the label for the pitch - fix the default setting value, so that the checkbox is consistent - use numpy slices instead of looping over each element, for performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a simple 3-Harmonic Product Spectrum. It works well when tested on my own voice (whereas Fmax often makes an octave error with the first overtone).