Escape key for alias to support using $ prefix in place of @

[Telokis]

In my config I use the $ prefix to point to my own directories and avoid having to type ../../../ everywhere.
Here is an example:

"alias": {
    "$src": "./src",
    "$common": "../Common",
    "$config": "./config",
    "^\\$(.+)": "./src/\\1"
}

The last one will simply convert anything beginning with $ to a directory/file inside my src directory. ($helpers/ becomes ./src/helpers/)

I noticed that you don't regex escape the key before using it.

Would you accept a PR to fix this?

By the way, for anyone looking for a solution to this problem, you can manually escape your keys in the config. In my case, it will become:

"alias": {
    "\\$src": "./src",
    "\\$common": "../Common",
    "\\$config": "./config",
    "^\\$(.+)": "./src/\\1"
}

and this works.

[tleunen]

@fatfisz - You pretty much coded this feature with regex. Would you mind taking a look? :) Not sure if there were any reason to that?

Not sure what to do when you really want to use one of these specific regex characters. Like.. Forcing the end of the regex with $? But again, how useful is it?
With babel 7 and a js file as a config, we could support regexes out of the box instead as well.

[Telokis]

To me it really seemed to be a simple forgotten detail in the code. The current handling is nice and I submitted #313 to fix the issue and add a test case.
You can't force users to use a js config if they want to use regexes. I think the current way of handling is not bad since nobody complained about it!
In my case, the $ is at the beginning of the match so it doesn't trigger a regex matching.

[tleunen]

Oh, I believe you're right @Telokis. Thanks for the additional info. I'll take a deeper look in the next few days.

It doesn't have anything to do with the regexes actually. Not the ones we detect when it starts with ˆ or ends with $. So that's why I was all mixed up. But I believe you're right with the escaping here.

[fatfisz]

Hi, I'll be able to finally take a look at this today, later in the evening.

[fatfisz]

Yup, it looks like I overlooked this. Thanks for contributing the fix ❤️

[Telokis]

My pleasure!