Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ScramException for malformed messages #11

Closed
wants to merge 1 commit into from
Closed

Raise ScramException for malformed messages #11

wants to merge 1 commit into from

Conversation

half-duplex
Copy link
Contributor

ProgVal pointed out that scramp doesn't catch KeyErrors for some malformed messages, which makes ensuring reliability and polite failures more challenging. This attempts to catch errors like that and raise a descriptive ScramException instead.

@tlocke
Copy link
Owner

tlocke commented Nov 1, 2022

Thanks for this patch @half-duplex, I've included it in the latest release 1.4.4. I'll close this PR, but let me know if there are still problems.

@tlocke tlocke closed this Nov 1, 2022
@half-duplex half-duplex deleted the keyerror branch August 3, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants