Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PKCS#8 private keys #195

Merged
merged 6 commits into from
May 5, 2020
Merged

Add support for PKCS#8 private keys #195

merged 6 commits into from
May 5, 2020

Conversation

oyamauchi
Copy link
Contributor

Closes #113

@coveralls
Copy link

coveralls commented Apr 18, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.023% when pulling 2cc9246 on oyamauchi:pkcs8 into d2f787e on warner:master.

tomato42
tomato42 requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#113 asked for both import and export of PKCS#8 format

@tomato42 tomato42 added the feature functionality to be implemented label Apr 20, 2020
@tomato42
Copy link
Member

the branches identified by coveralls as missing coverage should also be unit tested

oyamauchi
oyamauchi commented Apr 20, 2020
View reviewed changes
Copy link
Contributor Author

@oyamauchi oyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make those changes and add test coverage; just one question about detecting the format.

@oyamauchi
Copy link
Contributor Author

I don't see how my changes could have caused this decrease in code coverage (the python3.3 version of hmac_compat not getting called).

tomato42
tomato42 requested changes May 4, 2020
View reviewed changes
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how my changes could have caused this decrease in code coverage (the python3.3 version of hmac_compat not getting called).

yes, there's one test case that's non-deterministic (it's generating numbers and tests them for primality) and causes the overall coverage to jump by that 0.4%, don't worry about it

tomato42
tomato42 approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@tomato42
Copy link
Member

tomato42 commented May 5, 2020

awesome, thank you!

@tomato42 tomato42 merged commit a776084 into tlsfuzzer:master May 5, 2020
@oyamauchi oyamauchi deleted the pkcs8 branch May 5, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomato42 tomato42 tomato42 approved these changes

Assignees
No one assigned
Labels
feature functionality to be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for PKCS#8 file format
3 participants
@oyamauchi @coveralls @tomato42