handle non-prime order curves more gracefully #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
force-pushed
the
non-prime-order-curve
branch
3 times, most recently
from
bb3c719
to
0f2e764
Compare
tomato42
force-pushed
the
non-prime-order-curve
branch
2 times, most recently
from
30067c2
to
bed582b
Compare
when the order of the curve is not a prime, then point doubling can return INFINITY, this will cause some negative values not to be reduced modulo curve p; fix this
tomato42
force-pushed
the
non-prime-order-curve
branch
from
bed582b
to
7426df8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| enc = b'\x06' + enc[1:] | ||
|
|
||
| with self.assertRaises(MalformedPointError): | ||
| b = VerifyingKey.from_string(enc, valid_encodings=("hybrid",)) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
ZoltanFridrich
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the order of the curve is not a prime, then point doubling can return INFINITY, this will cause some negative values not to be reduced modulo curve p; fix this
fixes #343