Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

628 notary server openapiyaml #651

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

maceip
Copy link
Collaborator

@maceip maceip commented Oct 24, 2024

No description provided.

@maceip maceip requested a review from yuroitaki October 24, 2024 04:08
@maceip maceip linked an issue Oct 24, 2024 that may be closed by this pull request
@maceip maceip changed the base branch from main to dev October 24, 2024 04:08
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.35%. Comparing base (1d66359) to head (161f639).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #651   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files         192      192           
  Lines       20473    20473           
=======================================
  Hits        11129    11129           
  Misses       9344     9344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a few cosmetic nits

type: object
properties:
rawQuote:
description: hex bytes representing the signed-by-intel quote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: hex bytes representing the signed-by-intel quote
description: Hex bytes representing the signed-by-intel quote

description: hex bytes representing the signed-by-intel quote
type: string
mrsigner:
description: the key bound to the enclave = ephemeral = not used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: the key bound to the enclave = ephemeral = not used
description: The key bound to the enclave = ephemeral = not used

description: the key bound to the enclave = ephemeral = not used
type: string
mrenclave:
description: the enclave image hash, including gramine and the notary-server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: the enclave image hash, including gramine and the notary-server.
description: The enclave image hash, including gramine and the notary-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notary-server: openapi.yaml
2 participants