We can recommend conditional compilation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that this will change what is deployed.
|
Looks good to me! |
hannestschofenig
approved these changes
Feb 18, 2025
boaks
reviewed
Feb 22, 2025
| used in a production system. | ||
| used in a production system. For software that is compiled, use of conditional | ||
| compilation is the best way to ensure that deployed binaries cannot be | ||
| configured to enable key logging. |
There was a problem hiding this comment.
That assumes, that someone has access to the "configuration mechanism", but is not able to exchange the executable. Otherwise you may need to add "proprietary" software. Because for the most "open source" application an attacker may just build it with the switch enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.