-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper bound from Python version specifier #249
Remove upper bound from Python version specifier #249
Conversation
Thanks for the PR @sisp. I'll have a read of those articles/PRs this evening. What are the downsides to removing the maximum Python version? |
@kiancross Poetry will throw an error during dependency resolution when any of the dependencies in the tree uses a maximum version. To fix that, the project itself needs to declare that maximum version, too. That's one of the reasons why this bad practice is spreading; a library author - when using Poetry - may be forced to add the upper bound because one of the dependencies has it. |
Any update on this PR, @kiancross? |
Check also |
This will simply allow downstream Poetry and |
Exactly. |
By removing the cap, are we stating we support Python |
Correct, and the consensus is that this is fine despite no guarantee at this point that |
Ok. Just waiting for #270 to fix the current CI issues, then I will merge this after. Sorry for the delay, and thanks for your contribution :) |
I'll also be needing this :D. Thanks sisp! |
Once the minor merge conflict is resolved, I can merge. If you don't have time to fix, I can merge the branches later:) |
@kiancross I've resolved the merge conflict. |
What is the problem that this PR addresses?
Capping the Python version (e.g.
<4
) is a bad practice.How did you solve it?
I've removed the upper bound, i.e. I've replaced the version specifier
^
by>=
.Checklist