Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge styles with Choice custom styles #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahnucl
Copy link

@ahnucl ahnucl commented Feb 16, 2024

Allow selected and highlighted styles to work with Choice custom styles.

What is the problem that this PR addresses?
I needed the hightlighting functionality with custom styles no my Choices.

#151
...

How did you solve it?
I found that when the title param on Choice is a list it just extend the styles not checking if selected or hightlighted exists

...

Checklist

  • I have read the Contributor's Guide.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Allow selected and highlighted styles to work with Choice custom styles.
@kiancross
Copy link
Collaborator

@ahnucl Please can you update this branch with latest changes from master and then I will review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants