vectorstores: add Replacement option
#1062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes introduce a `Replacement` member to the vectorstores options. This option can be used in `AddDocuments` function. When Replacement is set to `true`, AddDocuments function will delete old record with the same Metadata attribute. (i.e to cover or to replace). When Replacement is set to `false`(default case), AddDocuments function will simply add documents without checking existing document records.
- add doc for `WithReplacement` opt - add test in pgvector_test
odannyc
reviewed
Nov 23, 2024
| // when adding documents. If set to true, the existing document with the **Metadata** will | ||
| // be replaced with the new document. If set to false(default case), the new document will | ||
| // be added to the store and the existing document will be kept. | ||
| func WithReplacement(replacement bool) Option { |
There was a problem hiding this comment.
I see this only implemented in pgvector. I would love to see all other stores implement this option, or atleast initially return a not implemented error.
|
@creeper12356 can you refresh this and as mentioned above have some non-implementation case for other stores would be nice. |
|
@tmc I will try to refresh this in one month. Thanks for noticing. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vectorstores: add
ReplacementoptionThis PR introduce a
Replacementmember to the vectorstores options. This option can be used inAddDocumentsfunction.When Replacement is set to
true, AddDocuments function will delete old record with the same Metadata attribute. (i.e to replace).When Replacement is set to
false(default case) , AddDocumentsfunction will simply add documents without checking existing
document records.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.