Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llms: implement StreamingReasoningFunc for reasoning models #1125

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

douglarek
Copy link
Contributor

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@douglarek douglarek marked this pull request as draft February 2, 2025 11:46
@douglarek douglarek force-pushed the openai-resoning branch 2 times, most recently from fbb682b to b6ce64d Compare February 2, 2025 12:21
@douglarek douglarek marked this pull request as ready for review February 2, 2025 12:35
@tmc
Copy link
Owner

tmc commented Feb 5, 2025

Thanks for your contribution! Can you follow on with an example please?

@douglarek
Copy link
Contributor Author

Thanks for your contribution! Can you follow on with an example please?

Okay, the deepseek example has been reused.

@tmc tmc changed the title feat: implement StreamingReasoningFunc for resoning models feat: implement StreamingReasoningFunc for reasoning models Feb 13, 2025
@tmc tmc merged commit d3e43b6 into tmc:main Feb 13, 2025
3 checks passed
tmc added a commit that referenced this pull request Feb 13, 2025
@tmc
Copy link
Owner

tmc commented Feb 13, 2025

Wups I merged this prematurely.

@tmc tmc changed the title feat: implement StreamingReasoningFunc for reasoning models llms: implement StreamingReasoningFunc for reasoning models Feb 13, 2025
@douglarek douglarek deleted the openai-resoning branch February 13, 2025 05:57
hisunwei pushed a commit to tmrwh/langchaingo that referenced this pull request Feb 18, 2025
* feat: implement StreamingReasoningFunc for resoning models

* Using deepseek example for streaming reasoning content
@Hades32
Copy link

Hades32 commented Feb 18, 2025

did you test this with OpenAI? From my testing they fail when the temperature parameter is not removed. See #1129

@douglarek
Copy link
Contributor Author

did you test this with OpenAI? From my testing they fail when the temperature parameter is not removed. See #1129

This is a merged PR, please open a new issue for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants