Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve bedrock provider extraction from model id #1135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucaronca
Copy link
Contributor

@lucaronca lucaronca commented Feb 6, 2025

Currently, the bedrock implementation assumed that the model ID would start with the provider name, which meant it can't handle cases like passing the ARN as the model ID or where model ID uses a different format. For instance, AWS customer support recommends using a custom-formatted model ID to work around a bedrock bug (see: AWS Repost). I have now updated the code to extract the provider using a more flexible approach that supports these custom formats.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@lucaronca lucaronca force-pushed the fix-bedrock-provider-parsing branch from 2dfcb70 to da94ebf Compare February 6, 2025 17:22
@lucaronca lucaronca changed the title fix: improve bedrock provider extraction from model id fix: Improve bedrock provider extraction from model id Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant