Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddings: use NewEmbedder for OpenAI embeddings #385

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

eliben
Copy link
Collaborator

@eliben eliben commented Dec 1, 2023

This is the first use of the refactoring made in #374 -- removing the embeddings/openai directory entirely, since it can be now implemented with NewEmbedder without duplicating code. The test was moved one dir down and works with the new setup.

This is a model that can be used to similarly refactor the other embeddings/* subdirs.

This is a large PR because it also updates example go.mods

For #379

PR Checklist

  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

This is the first use of the refactoring made in tmc#374 -- removing the
embeddings/openai directory entirely, since it can be now implemented
with NewEmbedder without duplicating code. The test was moved one
dir down and works with the new setup.

This is a model that can be used to similarly refactor the other
embeddings/* subdirs.

This is a large PR because it also updates example go.mods

For tmc#379
@eliben
Copy link
Collaborator Author

eliben commented Dec 1, 2023

@tmc for your review

@zivkovicn FYI

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@tmc tmc merged commit 00bd62f into tmc:main Dec 1, 2023
3 checks passed
@nidzola
Copy link
Contributor

nidzola commented Dec 1, 2023

@eliben nice work! Tnx

tmc pushed a commit that referenced this pull request Dec 5, 2023
This is the first use of the refactoring made in #374 -- removing the
embeddings/openai directory entirely, since it can be now implemented
with NewEmbedder without duplicating code. The test was moved one
dir down and works with the new setup.

This is a model that can be used to similarly refactor the other
embeddings/* subdirs.

This is a large PR because it also updates example go.mods

For #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants