Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example about retriever #651

Merged
merged 3 commits into from
Mar 13, 2024
Merged

docs: Add example about retriever #651

merged 3 commits into from
Mar 13, 2024

Conversation

devalexandre
Copy link
Contributor

A example about retriever, how use and why need use

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

A example about retriever, how use and why need use
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, a small comment that i think would improve readability/interpretability.

@tmc
Copy link
Owner

tmc commented Mar 8, 2024

I'm happy to accept this change but will hold off for a bit so you have an opportunity to add a bit more detail as requested

@devalexandre devalexandre requested review from corani and tmc March 8, 2024 12:42
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc changed the title Example about retriever docs: Add example about retriever Mar 13, 2024
@tmc tmc merged commit 04e2df3 into tmc:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants