Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llms/bedrock: Add AWS Bedrock LLMs #666

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Conversation

sansmoraxz
Copy link
Contributor

@sansmoraxz sansmoraxz commented Mar 12, 2024

Adding bedrock LLMs.

Namely the models from following providers:-

  • A21 Labs (Jurrasic Mid & Ultra)
  • Amazon (Titans)
  • Claude (v1-instant, v2, v2.1, v3-sonnet, v3-haiku)
  • Cohere Command (Normal & Lite)
  • Meta (Llama 2- 13B and 70B Chat)

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@sansmoraxz sansmoraxz changed the title Feature: Add AWS Bedrock LLMs LLMs: Add AWS Bedrock LLMs Mar 12, 2024
@sansmoraxz
Copy link
Contributor Author

Also IMO some CallOptions should be of pointer type, otherwise there is no way to differentiate unpassed parameters. For instance, temperature value 0 may be set explicitly or it may just be the default value (which would in turn overload LLM defaults).

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment new exported symbols.

sansmoraxz and others added 3 commits March 14, 2024 20:18
- Add haiku
- Make sonnet model name consistent
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, can you follow up and open a PR to add examples for this? Great contribution!

@tmc tmc merged commit 259311e into tmc:main Mar 18, 2024
3 checks passed
@tmc tmc changed the title LLMs: Add AWS Bedrock LLMs llms: Add AWS Bedrock LLMs Mar 18, 2024
@tmc tmc changed the title llms: Add AWS Bedrock LLMs llms/bedrock: Add AWS Bedrock LLMs Mar 18, 2024
@sansmoraxz sansmoraxz deleted the feature/bedrock-llms branch March 20, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants