Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search widget buffer sizing #119

Closed
tr3vorm opened this issue May 15, 2017 · 6 comments
Closed

Search widget buffer sizing #119

tr3vorm opened this issue May 15, 2017 · 6 comments

Comments

@tr3vorm
Copy link

tr3vorm commented May 15, 2017

I have had someone report a problem with the buffer sizes when searching by shape. I can reproduce the problem by following these steps.

  1. Search an attribute by shape
  2. Draw a shape (e.g. a point.
  3. Set the buffer to e.g. 100m
  4. Use the measure tool to check the buffer size (it is correct).
  5. Click the search button
  6. The buffer shrinks to ~77m and only includes results within the 77m

Subsequent changes to the search shape get drawn correctly, but then it is changed when performing the search. I am wondering if this problem has appeared before, or is it specific to our configuration?

@tr3vorm
Copy link
Author

tr3vorm commented May 15, 2017

I am working through the code as I noticed that the search widget is out of date. Will report back when I have the new code working.

@tr3vorm
Copy link
Author

tr3vorm commented May 15, 2017

After updating the widget code (Search and Attribute Table) to the current code, the buffer size error is no more. I still have another error related to infoTemplates (assume its my config) but will open another issue if I cannot resolve it.

@tr3vorm tr3vorm closed this as completed May 15, 2017
@tmcgee
Copy link
Owner

tmcgee commented May 15, 2017

The error related to infoTemplates is a new addition and something I am in the middle of working on. This is the fix for line 366 of Search.js:

infoTemplates: lang.clone(search.infoTemplates || layer.infoTemplates || {})

@tr3vorm
Copy link
Author

tr3vorm commented May 16, 2017

Many thanks! I was struggling infoTemplates in the search config.

One minor bug I see is that the attribute table has it's headings overwritten with the results if there is a FindTask() instead of a QueryTask() in the search widget config. I can create a new issue as I doubt it is related to anything here.

@tmcgee
Copy link
Owner

tmcgee commented May 16, 2017

@tr3vorm I have commited/pushed the fix for infoTemplates to this repo.

I see what you are referring to regarding FindTask though do not have an immediate fix. Please create another issue so we can track this separately.

tmcgee added a commit that referenced this issue May 16, 2017
@tmcgee
Copy link
Owner

tmcgee commented May 16, 2017

@tr3vorm issue with FindTask fixed in d565619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants