Add rudimentary parser for Git config files #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiste
reviewed
Apr 1, 2022
Follow the dune spirit, i.e. stop prefixing modules with `Gitconfig_`.
|
I implemented @maiste's suggestions, and implemented utility functions to find |
OlivierNicole
force-pushed
the
parse_gitconfig
branch
from
97b5c91
to
327e557
Compare
|
Things are probably still a bit brittle, there may be corner cases in the parser or in the project name extractor that I didn't consider, but I think it can be a decent start. |
|
Thanks @OlivierNicole I'll merge this and people can create PRs for the various commands that should use this to guess the right project to use. |
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Apr 4, 2022
CHANGES: ## Added * Various changes to rework lab cli client. (tmcgilchrist/ocaml-gitlab#50 tmcgilchrist/ocaml-gitlab#51 @maiste @tmcgilchrist @OlivierNicole) ## Bug fixes * Strip api/v4 from authorize and token url during OAuth. (tmcgilchrist/ocaml-gitlab#48 @tmcgilchrist) * Serialise milestone_id is an int. (tmcgilchrist/ocaml-gitlab#48 @tmcgilchrist) * Various merge_request webhook deserialisation fixes. (tmcgilchrist/ocaml-gitlab#47 @tmcgilchrist) * Fix incorrect field name, detected with atdgen 2.3.x (tmcgilchrist/ocaml-gitlab#46 @mjambon) * Fix commit_short_webhook prefix typo (tmcgilchrist/ocaml-gitlab#45 @MisterDA) * Update GHA to use windows-2022 (tmcgilchrist/ocaml-gitlab#44 @MisterDA) * Fix subcommands names and document env vars (tmcgilchrist/ocaml-gitlab#44 @MisterDA) * Document GITLAB_ env vars via Cmdliner (tmcgilchrist/ocaml-gitlab#44 @MisterDA) * Update cmdliner 1.1.0 API (tmcgilchrist/ocaml-gitlab#41 @MisterDA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing
.git/configshould be useful to get the remote URLs, and hence the project name in Gitlab (the project name, or its ID, is needed to perform project-related requests to the API).Is it a nice parser? No. Does it already exist elsewhere in a better version? Probably, although I couldn't find it. Git config files seem to be a form of INI files.
For now, nested sections are not supported properly. (They will parse, but the result will not be a hierarchy of sections.)