Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
apacheGH-41164: [C#] Fix concatenation of sliced arrays (apache#41245)
### Rationale for this change Makes array concatenation work correctly when the input arrays have been sliced. ### What changes are included in this PR? * Updates the array concatenation tests so that the `TestDataGenerator` can generate test cases with sliced input arrays. To avoid too much duplicated logic, I've added a new `GenerateTestData<TArray, TArrayBuilder>` method that works with builders that are not `IArrowArrayBuilder<T, TArray, TArrayBuilder>`, and simplified a lot of the data generation by using this new method. Only struct and union array test data generation still needs to duplicate the logic in `GenerateTestData`. * Fixes `ArrayDataConcatenator` logic to handle sliced input arrays ### Are these changes tested? Yes, I've added a new test for this. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41164 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
- Loading branch information