-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions regarding strong and em #23
Comments
tmcw
added a commit
that referenced
this issue
Mar 18, 2017
This fixes a bug that remains in base.css, where it used explicit font family names and classes instead of relying on the browser to associate faces with styles. Fixes #23
Yeah, sorry about this. This is the result of an still-present bug in base.css, where it used web fonts incorrectly, in a systematic way that spread the problem around. I've just implemented #24, which should fix this issue - can you check it out and see if it resolves the problem? |
Done ! LGTM ! |
tmcw
added a commit
that referenced
this issue
Mar 18, 2017
This fixes a bug that remains in base.css, where it used explicit font family names and classes instead of relying on the browser to associate faces with styles. Fixes #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm trying to wrap my head around an issue I'm encountering with
**strong**
and*emphasised*
texts: they are just rendered as vanilla paragraph text on my system, instead of the expected strong and italic text.I've noticed that the css rules specifically reset the font property of the
strong
andem
tags (in css/base.css, and also later on forstrong
), and use bold and italic fonts instead (Open Sans Bold, and Open Sans Italic). While this works well on the Mapbox API page because the aforementioned fonts are served to the visitor, I'm afraid most developers would not want to do the same.I'm not sure I understand the reason behind this choice, rather than just using vanilla properties of the tags.
Several tweaks may do the trick:
strong
andem
(or maybe dofont-family: inherit
instead offont: inherit
),font-weight: normal
for.strong
.What do you think ?
BR
The text was updated successfully, but these errors were encountered: