.NET Standard 2.0 package

[MihaMarkic]

Hi guys,

It'd be nice if you included a .NET Standard 2.0 package. Otherwise a lot of NuGet references is dragged into a Xamarin project.

[tmenier]

Makes sense to me. Will plan on getting this in the next release.

[kroniak]

Hi. You can use flurl.http 1.4 package in your 2.0 lib.

[MihaMarkic]

@kroniak I know. But that's not the point.

[kroniak]

Why do you want exactly 2.0? пт, 9 февр. 2018 г., 0:41 Miha Markič <notifications@github.com>:

…

@kroniak <https://github.com/kroniak> I know. But that's not the point. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#267 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbu35HPKVqV9iLIOYZ6fs1NWfvmt71xks5tS2nugaJpZM4RrE30> .

[MihaMarkic]

@kroniak As I wrote. When adding existing NuGet package to Xamarin, it would reference a ton of other NuGet packages. Which isn't the case if it is build for .NET Standard 2.

[tmenier]

@MihaMarkic Out of curiosity, is the "ton of other NuGet packages" just something developers see when they install Flurl or does it actually result in a more bloated compiled app that end-users install on their phone?

[tmenier]

@kroniak Everything builds fine by just adding netstandard2.0 to <TargetFrameworks> and making a tweak to one of the #if directives. However, would doing this "right" mean lots of changes to build/test scripts etc?

[kroniak]

@tmenier #273

[MihaMarkic]

@tmenier TBH I do not know if there is a bloat added to the compiled app. It is bad enough (to me) that I get my nuget references polluted so I never went investigating what actually happens.

[tmenier]

@kroniak Thanks! I was already working on it myself and we ended up with the same results, which tells me I was probably doing it right. :)

Do you have an opinion on having package testers for both .NET Core 1.x and 2.x? I sometimes wonder if they're needed at all, but the way they share code, adding a new one requires almost no new code.

[kroniak]

@tmenier I think we can have only .netcore app 2.0

[tmenier]

@kroniak Is it strange that System.Reflection.TypeExtensions is required in netstandard1.3 but not 1.0 or 2.0?

https://github.com/tmenier/Flurl/blob/master/src/Flurl/Flurl.csproj#L28-L30

Could be right, I just wanted to make sure.

[tmenier]

@MihaMarkic The latest prerelase contains a netstandard2.0 target. Please test it and let me know if it's what you're expecting:

https://www.nuget.org/packages/Flurl.Http/2.2.0-pre1

[kroniak]

@tmenier I think same. It is strange. But it does not need any package in std2.0 https://www.nuget.org/packages/System.Reflection.TypeExtensions/

[tmenier]

Well this isn't very nice:

That's for the .NET Core 2.0 package tester. Fortunately I found the culprit - Json.NET 10.0.3 accounts for most of it. 11.x has a netstandard2.0 target with exactly zero dependencies. So needless to say there will be another prerelease.

[tmenier]

That's better...

CodePages is necessary because of this.

[tmenier]

Full version is released.

[MihaMarkic]

Thanks guys. It works fine now.