Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc breaking changes for 4.0 #738

Closed
tmenier opened this issue Dec 30, 2022 · 2 comments
Closed

Misc breaking changes for 4.0 #738

tmenier opened this issue Dec 30, 2022 · 2 comments
Labels
4.0 breaking enhancement

Comments

@tmenier
Copy link
Owner

tmenier commented Dec 30, 2022 •
edited
Loading

Some general refactoring aimed at simplifying some core Flurl.Http classes and interfaces resulted in a few breaking changes. This issue is catch-all to make sure those get documented.

  • FlurlClient.Settings and FlurlRequest.Settings container objects are read-only.
  • FlurlClient.HttpMessageHandler removed.
  • FlurlCall.RedirectedFrom moved to IFlurlRequest.
  • FlurlResponse ctor takes a FlurlCall instead of an HttpResponseMessage.
  • FlurlRequest.Client is no longer instantiated on demand by just referencing the property. If it hasn't been set explicitly, or (more common) by calling FlurlClient.Request, it will remain null until the request is sent.
tmenier added a commit that referenced this issue Dec 30, 2022
@tmenier
#738 refactoring, mostly around simplifying FlurlRequest
5667584
@ngoquoctoandev
Copy link

I'm looking forward to significant improvements in version 4.0. Long time no see a maintainer/contributor to this super awesome project.

@tmenier
Copy link
Owner Author

tmenier commented May 25, 2023

Haven't had much time. Will soon. Thanks for your patience.

@tmenier tmenier closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 breaking enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmenier @ngoquoctoandev