Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH601: Enable snupkg symbol packages #628

Merged
merged 2 commits into from
May 14, 2022
Merged

GH601: Enable snupkg symbol packages #628

merged 2 commits into from
May 14, 2022

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 9, 2021

Following up from #601.

@gitfool
Copy link
Contributor Author

gitfool commented May 9, 2021

@tmenier PTAL. Re deterministic builds, I'm assuming the NuGet packages that are published are built on AppVeyor.

@gitfool
Copy link
Contributor Author

gitfool commented May 9, 2021

Downloading AppVeyor 39079294 artifacts:

Flurl.3.0.2.nupkg:
image

Flurl.3.0.2.snupkg:
image

@tmenier
Copy link
Owner

tmenier commented May 7, 2022

Given that it's been a full year since you opened this (yikes...sorry!) can I assume this is still necessary in .NET 6 and still the most modern/recommended way of doing this? Also is it safe to assume it won't adversely affect anyone's dev experience? I'm about to start on 4.0 and wondering if this should go in the final 3.x maintenance release or the first 4.0 prerelease.

As I mentioned in #601, this isn't my area of expertise so I'm going to trust your judgement here. Thanks! :)

@gitfool
Copy link
Contributor Author

gitfool commented May 9, 2022

Yes, I think the issue I mention in #601 (comment) is only going to be addressed in the dotnet 7 sdk. That and publishing a separate snupkg seems to be the recommended way now. 😅

If you want to publish a maintenance release with this change then I'll make sure to confirm that I can still step debug with it.

@tmenier tmenier merged commit b38ee2a into tmenier:dev May 14, 2022
@gitfool gitfool deleted the gh601 branch May 14, 2022 10:05
@tmenier
Copy link
Owner

tmenier commented May 16, 2022

I was hoping I could get this published quickly so you could test it but it looks like the snupkg needs to be uploaded separately and I have no idea where to do that. I'll let you know when I figure that out.

@gitfool
Copy link
Contributor Author

gitfool commented May 16, 2022

How are you publishing now? IIRC, it should just work given the changes I made...

@tmenier
Copy link
Owner

tmenier commented May 16, 2022

I upload the nupkg to nuget.org.

@gitfool
Copy link
Contributor Author

gitfool commented May 16, 2022

Using what command? That command should handle uploading the snupkg too.

@tmenier
Copy link
Owner

tmenier commented May 18, 2022

Using the web site. I publish the packages manually and I don't see a place to upload a symbols package.

@tmenier
Copy link
Owner

tmenier commented May 18, 2022

Doh...I stand corrected - you can totally do it from the web UI. Same upload box even. Don't know how I missed that! I'm getting this (pre)released now.

I know my processes could use improving and I'd love to move off of AppVeyor and on to GH Actions, then automate releases. But like with so many things I just haven't had the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants