Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppendQueryParam(s) methods #689

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Add AppendQueryParam(s) methods #689

merged 2 commits into from
Sep 15, 2023

Conversation

Marusyk
Copy link
Contributor

@Marusyk Marusyk commented May 13, 2022

Fixes #688

Please review
Thank you in advance

@tmenier
Copy link
Owner

tmenier commented May 20, 2022

Wow, thank you for doing this. The main "problem" is you did it too soon. :) I just released what I'd consider the final 3.x versions and am embarking on 4.0 now. This one wasn't a high priority and my time is limited, but since you did it already I will try to get to it sooner than I otherwise would have.

One quick observation is I think about half the generated AppendQueryParam overloads should probably be AppendQueryParams (plural). It looks like you figured out how to auto-gen most of the code with that Metadata class, which is great.

So if you can be patient with me I will give it a more thorough review and merge it eventually. :)

@Marusyk
Copy link
Contributor Author

Marusyk commented May 24, 2022

Hi @tmenier
no problem put it on hold
in the meanwhile, I'll update AppendQueryParam -> AppendQueryParams

@tmenier tmenier merged commit b5768a9 into tmenier:dev Sep 15, 2023
1 check failed
@tmenier
Copy link
Owner

tmenier commented Sep 15, 2023

A year on and this is finally merged...thanks again!

@Marusyk Marusyk deleted the rmarusyk/688 branch September 16, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppendQueryParam(s) methods
2 participants