Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue Preservation #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pippenofbrightwood
Copy link

Simple changes! This branch has only a few additional features.

  1. I've added a replacement pattern for quote blocks, which means dialogue shouldn't ever be broken.
  2. I've added logic to break huge links (really, only quotes) across multiple messages.
  3. Quality of life features that let the user know if they're missing a quotation mark that would ruin their formatting, or if they've got the AFK tag on, before sending their emote.

The goal with these changes is to let writers focus on writing, rather than making sure their quotes land within chunks. The addon, now, will handle preserving the legibility of dialogue, doing its best not to step on the author's toes.

Example message without changes:
emotesplitterregular

Example message with changes:
emotesplitterquotable

I'd appreciate if you could take a look at these changes, and consider adding them to the main branch– in some form or another. :)

@tmg-pub
Copy link
Owner

tmg-pub commented Jan 7, 2024

Hi bestie, for changes like these I'd prefer not to have them in the main version. I'd say that the complexity for it outweighs the benefit. It does look better but there are so many corner cases with quote detection and unpredictability in how people use quotes.

It is a marked improvement for your example given, and I'd suggest releasing this as a patch for those who want it.

The main issue I'd say is the white highlighting. An alternate approach may be to modify that highlight code to detect the split marks in the text, to resume highlighting on the next message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants