Skip to content

Commit

Permalink
fix: Feast create empty online table when FeatureView attribute onlin…
Browse files Browse the repository at this point in the history
…e=False

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
tmihalac committed Oct 22, 2024
1 parent 9ca1452 commit 5c987b3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,12 @@ def update_infra(
):
# Call update only if there is an online store
if self.online_store:
tables_to_keep_online = [fv for fv in tables_to_keep if not isinstance(fv, FeatureView) or fv.online]

self.online_store.update(
config=self.repo_config,
tables_to_delete=tables_to_delete,
tables_to_keep=tables_to_keep,
tables_to_keep=tables_to_keep_online,
entities_to_keep=entities_to_keep,
entities_to_delete=entities_to_delete,
partial=partial,
Expand Down

0 comments on commit 5c987b3

Please sign in to comment.