Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 explicit implicits #641

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

amumurst
Copy link
Contributor

Give all public implicit def/val explicit type annotations which is required for compilation in scala 3

@amumurst
Copy link
Contributor Author

To find all of these I have compiled locally with scala 3. To do this I had to..

  • Published slick master locally with scala 3 support and use that
  • Removed scala-reflect in build.sbt for scala 3
  • Used play-json milestone M7
  • Commented out all macros (scala.reflect.runtime usage)
  • Changed 3-4 files to adhere to new slick changes

Then I used Intellijs "insert type annotation" on every compile error until it compiled :)

So except migrating the macros and releases of upstream libraries, this is all thats needed for scala 3 support :)

@tminglei tminglei merged commit 39e85d6 into tminglei:master Jun 5, 2023
@tminglei
Copy link
Owner

tminglei commented Jun 5, 2023

Merged. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants