-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACTION_MODS_ONESHOT(MOD_LSFT) doesn't work well / in an fn layer #248
Comments
You have to place the same action(ACTION_MODS_ONESHOT) on both layer when the action is relate to a modifier key(and layer switching key). This is a limitation of current TMK keymap design. https://github.com/tmk/tmk_keyboard/blob/master/doc/keymap.md#31-momentary-switching Keymap like the following doesn't work. Let's think following cases.
|
Thanks for the awesome explanation, I understand what the problem is now But here is my situation:
So I understood the cause, but I didn't understand the solution, or whether a solution exists (On the bright side, I can at least make the current setup work by releasing the keys in order) |
No workaround. |
- Idea form qmk/qmk_firmware#182 - Define NO_TRACK_KEY_PRESS to get old behaviour - This should resolve #105, #248, #397, #441 and FAQ entry: https://github.com/tmk/tmk_keyboard/wiki/FAQ-Keymap#modifierlayer-stuck
Fixed at ba2883f |
- Idea form qmk/qmk_firmware#182 - Define NO_TRACK_KEY_PRESS to get old behaviour - This should resolve tmk#105, tmk#248, tmk#397, tmk#441 and FAQ entry: https://github.com/tmk/tmk_keyboard/wiki/FAQ-Keymap#modifierlayer-stuck
- Idea form qmk/qmk_firmware#182 - Define NO_TRACK_KEY_PRESS to get old behaviour - This should resolve tmk#105, tmk#248, tmk#397, tmk#441 and FAQ entry: https://github.com/tmk/tmk_keyboard/wiki/FAQ-Keymap#modifierlayer-stuck
I have 2 FN layers, activated by keys A and B
When A is activated, pressing B triggers ACTION_MODS_ONESHOT(MOD_LSFT)
When B is activated, pressing A triggers ACTION_MODS_ONESHOT(MOD_LSFT)
So in theory, regardless of which keycap is pressed first, pressing A+B or B+A should trigger ACTION_MODS_ONESHOT(MOD_LSFT)
But this works 50% of the time, also sometimes the LSFT gets stuck, only pressing the LSFT manually gets it unstuck
(I'm using the usb-usb converter, so I'm wondering whether the speed related problem might originate from that, I need to press A+B together for at least 200-300ms for the one-shot to trigger, momentarily tapping them together doesn't work, even though I make sure they are pressed at the same time)
The text was updated successfully, but these errors were encountered: